stop winforms release build crashing

Author: LeftofZen

WinGui/MainForm.cs

@@ -201,20 +201,14 @@ void MainForm_Load(object sender, EventArgs e)
 			// can only do this after window handle has been created (so can't do in constructor)
 			((Logger)logger).LogAdded += (s, e) => lbLogs.Invoke(() => lbLogs.Items.Insert(0, e.Log));
 
-			InitUI(cbVanillaObjects.Checked, tbFileFilter.Text);
+			InitToolStripMenuItems();
 		}
 
 		void InitUI(bool vanillaOnly, string filter)
 		{
-			// required to load the object type images from g1.dat
-			//if (Directory.Exists(model.Settings.DataDirectory))
-			//{
-			//	_ = model.LoadDataDirectory(model.Settings.DataDirectory);
-			//}
-
+			InitToolStripMenuItems();
 			InitFileTreeView(vanillaOnly, filter);
 			InitCategoryTreeView(vanillaOnly, filter);
-			InitToolStripMenuItems();
 		}
 
 		bool LoadObjDataDirectory(string directory, bool useExistingIndex)

WinGui/MainFormModel.cs

@@ -54,23 +54,6 @@ public MainFormModel(ILogger logger, string settingsFile, PaletteMap paletteMap)
 			{
 				logger.Debug($"Preloading dependent {depObjectType} objects");
 			}
-
-			foreach (var dep in ObjectIndex.Objects.Where(x => x is ObjectIndexEntry oi && dependentObjectTypes.Contains(oi.ObjectType)))
-			{
-				var filename = Path.Combine(Settings.ObjDataDirectory, dep.Filename);
-#if DEBUG
-				SawyerStreamReader.LoadFullObjectFromFile(filename, logger);
-#else
-				try
-				{
-					SawyerStreamReader.LoadFullObjectFromFile(filename);
-				}
-				catch (Exception ex)
-				{
-					logger.Error($"File=\"{filename}\" Message=\"{ex.Message}\"");
-				}
-#endif
-			}
 		}
 
 		public EditorSettings Settings { get; private set; }
@@ -94,16 +77,7 @@ public void LoadSettings(string settingsFile)
 
 			Settings = settings!;
 
-			if (!ValidateSettings(Settings, logger))
-			{
-				return;
-			}
-
-			if (File.Exists(Settings.GetObjDataFullPath(Settings.IndexFileName)))
-			{
-				logger.Info($"Loading header index from \"{Settings.IndexFileName}\"");
-				LoadObjDirectory(Settings.ObjDataDirectory, new Progress<float>(), true);
-			}
+			_ = !ValidateSettings(Settings, logger);
 		}
 
 		static bool ValidateSettings(EditorSettings settings, ILogger logger)