Skip to content

Commit 33be906

Browse files
committed
fix unit tests
1 parent 2355851 commit 33be906

File tree

1 file changed

+22
-10
lines changed

1 file changed

+22
-10
lines changed

Tests/LoadSaveTests.cs

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,24 +67,36 @@ static void LoadSaveGenericTest<T>(string filename, Action<ILocoObject, T> asser
6767
// we could just simply compare byte arrays and be done, but i wanted something that makes it easier to diagnose problems
6868

6969
// grab headers first
70-
var bytes1S5Header = S5Header.Read(bytes1[0..S5Header.StructLength]);
71-
var bytes2S5Header = S5Header.Read(bytes2[0..S5Header.StructLength]);
70+
var s5Header1 = S5Header.Read(bytes1[0..S5Header.StructLength]);
71+
var s5Header2 = S5Header.Read(bytes2[0..S5Header.StructLength]);
7272

73-
var bytes1ObjHeader = ObjectHeader.Read(bytes1[S5Header.StructLength..(S5Header.StructLength + ObjectHeader.StructLength)]);
74-
var bytes2ObjHeader = ObjectHeader.Read(bytes2[S5Header.StructLength..(S5Header.StructLength + ObjectHeader.StructLength)]);
73+
var objHeader1 = ObjectHeader.Read(bytes1[S5Header.StructLength..(S5Header.StructLength + ObjectHeader.StructLength)]);
74+
var objHeader2 = ObjectHeader.Read(bytes2[S5Header.StructLength..(S5Header.StructLength + ObjectHeader.StructLength)]);
7575

7676
// then grab object bytes
7777
var bytes1ObjArr = bytes1[21..].ToArray();
7878
var bytes2ObjArr = bytes2[21..].ToArray();
7979

80-
Assert.Multiple(() =>
81-
{
82-
Assert.That(bytes2S5Header, Is.EqualTo(bytes1S5Header));
83-
Assert.That(bytes2ObjHeader, Is.EqualTo(bytes1ObjHeader));
84-
Assert.That(bytes1ObjArr.ToArray(), Is.EqualTo(bytes2ObjArr.ToArray()));
85-
});
80+
AssertS5Headers(s5Header1, s5Header2);
81+
AssertObjHeaders(objHeader1, objHeader2);
82+
Assert.That(bytes1ObjArr.ToArray(), Is.EqualTo(bytes2ObjArr.ToArray()));
8683
}
8784

85+
static void AssertS5Headers(S5Header expected, S5Header actual)
86+
=> Assert.Multiple(() =>
87+
{
88+
Assert.That(actual.Name, Is.EqualTo(expected.Name));
89+
Assert.That(actual.Flags, Is.EqualTo(expected.Flags));
90+
Assert.That(actual.Checksum, Is.EqualTo(expected.Checksum));
91+
});
92+
93+
static void AssertObjHeaders(ObjectHeader expected, ObjectHeader actual)
94+
=> Assert.Multiple(() =>
95+
{
96+
Assert.That(actual.Encoding, Is.EqualTo(expected.Encoding));
97+
Assert.That(actual.DataLength, Is.EqualTo(expected.DataLength));
98+
});
99+
88100
[TestCase("AIRPORT1.DAT")]
89101
public void AirportObject(string objectName)
90102
{

0 commit comments

Comments
 (0)