rename vehicle colourtype to specialcolourschemeindex

Author: LeftofZen

Dat/Objects/Vehicle/VehicleObject.cs

@@ -21,7 +21,7 @@ public record VehicleObject(
 		[property: LocoStructOffset(0x0A)] uint8_t Reliability,
 		[property: LocoStructOffset(0x0B)] uint8_t RunCostIndex,
 		[property: LocoStructOffset(0x0C)] int16_t RunCostFactor,
-		[property: LocoStructOffset(0x0E)] uint8_t ColourType,
+		[property: LocoStructOffset(0x0E)] uint8_t SpecialColourSchemeIndex, // this is an instance property and doesn't need to be saved in the definition as it can be calculated from other properties
 		[property: LocoStructOffset(0x0F)] uint8_t NumCompatibleVehicles,
 		[property: LocoStructOffset(0x10), LocoArrayLength(8), LocoStructVariableLoad] List<S5Header> CompatibleVehicles,
 		[property: LocoStructOffset(0x20), LocoArrayLength(4), LocoStructVariableLoad] List<S5Header> RequiredTrackExtras,

Gui/ViewModels/DatTypes/Objects/VehicleViewModel.cs

@@ -30,7 +30,7 @@ public class VehicleViewModel : LocoObjectViewModel<VehicleObject>
 		[Reactive, Category("Cost"), Range(0, int16_t.MaxValue)] public int16_t RunCostFactor { get; set; }
 		[Reactive, Category("<unknown>")] public uint8_t var_04 { get; set; }
 		[Reactive, Category("<unknown>")] public uint8_t var_113 { get; set; }
-		[Reactive, Category("Sprites")] public uint8_t ColourType { get; set; }
+		[Reactive, Category("Sprites")] public uint8_t SpecialColourSchemeIndex { get; set; } // called "ColourType" in the loco codebase
 		[Reactive, Category("Sprites"), Editable(false)] public BindingList<VehicleObjectCar> CarComponents { get; set; }
 		[Reactive, Category("Sprites"), Editable(false)] public BindingList<BodySprite> BodySprites { get; set; }
 		[Reactive, Category("Sprites"), Editable(false)] public BindingList<BogieSprite> BogieSprites { get; set; }
@@ -62,7 +62,7 @@ public VehicleViewModel(VehicleObject vo)
 			Reliability = vo.Reliability;
 			RunCostIndex = vo.RunCostIndex;
 			RunCostFactor = vo.RunCostFactor;
-			ColourType = vo.ColourType;
+			SpecialColourSchemeIndex = vo.SpecialColourSchemeIndex;
 			CompatibleVehicles = new(vo.CompatibleVehicles.ConvertAll(x => new S5HeaderViewModel(x)));
 			RequiredTrackExtras = new(vo.RequiredTrackExtras.ConvertAll(x => new S5HeaderViewModel(x)));
 			CarComponents = new(vo.CarComponents);
@@ -108,7 +108,7 @@ public override VehicleObject GetAsStruct(VehicleObject vo)
 				Reliability = Reliability,
 				RunCostIndex = RunCostIndex,
 				RunCostFactor = RunCostFactor,
-				ColourType = ColourType,
+				SpecialColourSchemeIndex = SpecialColourSchemeIndex,
 				Power = Power,
 				Speed = Speed,
 				RackSpeed = RackSpeed,

Tests/LoadSaveTests.cs

@@ -1006,7 +1006,7 @@ void assertFunc(ILocoObject obj, VehicleObject struc) => Assert.Multiple(() =>
 				Assert.That(struc.Reliability, Is.EqualTo(88), nameof(struc.Reliability));
 				Assert.That(struc.RunCostIndex, Is.EqualTo(4), nameof(struc.RunCostIndex));
 				Assert.That(struc.RunCostFactor, Is.EqualTo(55), nameof(struc.RunCostFactor));
-				Assert.That(struc.ColourType, Is.EqualTo(9), nameof(struc.ColourType));
+				Assert.That(struc.SpecialColourSchemeIndex, Is.EqualTo(9), nameof(struc.SpecialColourSchemeIndex));
 				Assert.That(struc.NumCompatibleVehicles, Is.EqualTo(0), nameof(struc.NumCompatibleVehicles));
 				//CollectionAssert.AreEqual(Enumerable.Repeat(0, 8).ToArray(), struc.CompatibleVehicles, nameof(struc.CompatibleVehicles));
 				//CollectionAssert.AreEqual(Enumerable.Repeat(0, 4).ToArray(), struc.RequiredTrackExtras, nameof(struc.RequiredTrackExtras));