[Fix] Pattern tab: r22668 broke the Toggle Follow Song shortcut (https://bugs.openmpt.org/view.php?id=1867)

sagamusix · sagamusix · commit 56125ede1713 · 2025-02-26T22:33:00.000Z
git-svn-id: https://source.openmpt.org/svn/openmpt/trunk/OpenMPT@22976 56274372-70c3-4bfc-bfc3-4c3a0b034d27
diff --git a/mptrack/Ctrl_pat.cpp b/mptrack/Ctrl_pat.cpp
@@ -504,10 +504,10 @@ LRESULT CCtrlPatterns::OnModCtrlMsg(WPARAM wParam, LPARAM lParam)
 	case CTRLMSG_PAT_FOLLOWSONG:
 		// parameters: 0 = turn off, 1 = toggle
 		{
-			UINT state = FALSE;
+			UINT state = BST_UNCHECKED;
 			if(lParam == 1)	// toggle
 			{
-				state = IsDlgButtonChecked(IDC_PATTERN_FOLLOWSONG) != BST_UNCHECKED;
+				state = (IsDlgButtonChecked(IDC_PATTERN_FOLLOWSONG) == BST_UNCHECKED) ? BST_CHECKED : BST_UNCHECKED;
 			}
 			CheckDlgButton(IDC_PATTERN_FOLLOWSONG, state);
 			OnFollowSong();

Original file line number	Diff line number	Diff line change
`@@ -504,10 +504,10 @@ LRESULT CCtrlPatterns::OnModCtrlMsg(WPARAM wParam, LPARAM lParam)`
`504`	`504`	`case CTRLMSG_PAT_FOLLOWSONG:`
`505`	`505`	`// parameters: 0 = turn off, 1 = toggle`
`506`	`506`	`{`
`507`		`- UINT state = FALSE;`
	`507`	`+ UINT state = BST_UNCHECKED;`
`508`	`508`	`if(lParam == 1) // toggle`
`509`	`509`	`{`
`510`		`- state = IsDlgButtonChecked(IDC_PATTERN_FOLLOWSONG) != BST_UNCHECKED;`
	`510`	`+ state = (IsDlgButtonChecked(IDC_PATTERN_FOLLOWSONG) == BST_UNCHECKED) ? BST_CHECKED : BST_UNCHECKED;`
`511`	`511`	`}`
`512`	`512`	`CheckDlgButton(IDC_PATTERN_FOLLOWSONG, state);`
`513`	`513`	`OnFollowSong();`