[Ref] Silence cppcheck false-positive.

manxorist · manxorist · commit fba20fe310a7 · 2025-02-26T11:34:30.000Z
git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.31@22975 56274372-70c3-4bfc-bfc3-4c3a0b034d27
diff --git a/soundlib/Sndfile.cpp b/soundlib/Sndfile.cpp
@@ -1039,13 +1039,13 @@ void CSoundFile::ResetChannels()
 {
 	m_SongFlags.reset(SONG_FADINGSONG | SONG_ENDREACHED);
 	m_PlayState.m_nBufferCount = 0;
-	for(auto &chn : m_PlayState.Chn)
+	for(CHANNELINDEX c = 0; c < static_cast<CHANNELINDEX>(std::size(m_PlayState.Chn)); ++c)
 	{
+		ModChannel &chn = m_PlayState.Chn[c];
 		chn.nROfs = chn.nLOfs = 0;
 		chn.nLength = 0;
 		if(chn.dwFlags[CHN_ADLIB] && m_opl)
 		{
-			CHANNELINDEX c = static_cast<CHANNELINDEX>(std::distance(m_PlayState.Chn.data(), &chn));
 			m_opl->NoteCut(c);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1039,13 +1039,13 @@ void CSoundFile::ResetChannels()`
`1039`	`1039`	`{`
`1040`	`1040`	`m_SongFlags.reset(SONG_FADINGSONG \| SONG_ENDREACHED);`
`1041`	`1041`	`m_PlayState.m_nBufferCount = 0;`
`1042`		`- for(auto &chn : m_PlayState.Chn)`
	`1042`	`+ for(CHANNELINDEX c = 0; c < static_cast<CHANNELINDEX>(std::size(m_PlayState.Chn)); ++c)`
`1043`	`1043`	`{`
	`1044`	`+ ModChannel &chn = m_PlayState.Chn[c];`
`1044`	`1045`	`chn.nROfs = chn.nLOfs = 0;`
`1045`	`1046`	`chn.nLength = 0;`
`1046`	`1047`	`if(chn.dwFlags[CHN_ADLIB] && m_opl)`
`1047`	`1048`	`{`
`1048`		`- CHANNELINDEX c = static_cast<CHANNELINDEX>(std::distance(m_PlayState.Chn.data(), &chn));`
`1049`	`1049`	`m_opl->NoteCut(c);`
`1050`	`1050`	`}`
`1051`	`1051`	`}`