refactor: use parameter manager directly in get_max_threads()

- Pass parameter_manager to get_max_threads() to read persisted value
- Remove session state copying workaround in StreamlitUI
- Cleaner design that reads directly from params.json

https://claude.ai/code/session_01XGuw7AxoKRWHr9EZX1SDXi

Author: claude

src/common/common.py

@@ -32,12 +32,15 @@
 OS_PLATFORM = sys.platform
 
 
-def get_max_threads() -> int:
+def get_max_threads(parameter_manager=None) -> int:
     """
     Get max threads for current deployment mode.
 
-    In local mode, checks for UI override in session state.
-    In online mode, uses the configured value directly.
+    In local mode, reads from parameter manager (persisted params.json).
+    In online mode, uses the configured value directly from settings.
+
+    Args:
+        parameter_manager: Optional ParameterManager instance for reading persisted params.
 
     Returns:
         int: Maximum number of threads to use for parallel processing.
@@ -48,11 +51,12 @@ def get_max_threads() -> int:
     if settings.get("online_deployment", False):
         return max_threads_config.get("online", 2)
     else:
-        # Local mode: check for UI override, fallback to config default
-        return st.session_state.get(
-            "max_threads_override",
-            max_threads_config.get("local", 4)
-        )
+        # Local mode: read from parameter manager if available
+        default = max_threads_config.get("local", 4)
+        if parameter_manager is not None:
+            params = parameter_manager.get_parameters_from_json()
+            return params.get("max_threads", default)
+        return default
 
 
 def is_safe_workspace_name(name: str) -> bool:

src/workflow/CommandExecutor.py

@@ -46,7 +46,7 @@ def run_multiple_commands(
         from src.common.common import get_max_threads
 
         # Get thread settings and calculate distribution
-        max_threads = get_max_threads()
+        max_threads = get_max_threads(self.parameter_manager)
         num_commands = len(commands)
         parallel_commands = min(num_commands, max_threads)
 
@@ -235,7 +235,7 @@ def run_topp(self, tool: str, input_output: dict, custom_params: dict = {}) -> b
 
         # Calculate threads per command based on max_threads setting
         from src.common.common import get_max_threads
-        max_threads = get_max_threads()
+        max_threads = get_max_threads(self.parameter_manager)
         parallel_commands = min(n_processes, max_threads)
         threads_per_command = max(1, max_threads // parallel_commands)
 

src/workflow/StreamlitUI.py

@@ -1120,10 +1120,6 @@ def parameter_section(self, custom_parameter_function) -> None:
                 min_value=1,
                 help="Maximum threads for parallel processing. Threads are distributed between parallel commands and per-tool thread allocation."
             )
-            # Copy to session state for get_max_threads() to access
-            prefixed_key = f"{self.parameter_manager.param_prefix}max_threads"
-            if prefixed_key in st.session_state:
-                st.session_state.max_threads_override = st.session_state[prefixed_key]
 
         # Display preset buttons if presets are available for this workflow
         self.preset_buttons()