refactor: pass workflow name explicitly to ParameterManager

- ParameterManager.__init__() now accepts optional workflow_name param
- WorkflowManager passes workflow name directly to ParameterManager
- load_presets() normalizes workflow name (lowercase, hyphens) for lookup
- Added tests for workflow_name parameter functionality

This makes the preset lookup contract clearer: presets.json keys should use
the normalized format (e.g., "topp-workflow" for "TOPP Workflow").

https://claude.ai/code/session_01BnipAqTf16J7kJVfnzah2U

Author: claude

src/workflow/ParameterManager.py

@@ -17,14 +17,17 @@ class ParameterManager:
         params_file (Path): Path to the JSON file where parameters are saved.
         param_prefix (str): Prefix for general parameter keys in Streamlit's session state.
         topp_param_prefix (str): Prefix for TOPP tool parameter keys in Streamlit's session state.
+        workflow_name (str): Name of the workflow, used for loading presets.
     """
     # Methods related to parameter handling
-    def __init__(self, workflow_dir: Path):
+    def __init__(self, workflow_dir: Path, workflow_name: str = None):
         self.ini_dir = Path(workflow_dir, "ini")
         self.ini_dir.mkdir(parents=True, exist_ok=True)
         self.params_file = Path(workflow_dir, "params.json")
         self.param_prefix = f"{workflow_dir.stem}-param-"
         self.topp_param_prefix = f"{workflow_dir.stem}-TOPP-"
+        # Store workflow name for preset loading; default to directory stem if not provided
+        self.workflow_name = workflow_name or workflow_dir.stem
 
     def create_ini(self, tool: str) -> bool:
         """
@@ -187,9 +190,9 @@ def load_presets(self) -> dict:
         except (json.JSONDecodeError, IOError):
             return {}
 
-        # Get workflow name from the workflow directory stem
-        workflow_name = self.ini_dir.parent.stem
-        return all_presets.get(workflow_name, {})
+        # Normalize workflow name to match preset keys (lowercase with hyphens)
+        workflow_key = self.workflow_name.replace(" ", "-").lower()
+        return all_presets.get(workflow_key, {})
 
     def get_preset_names(self) -> list:
         """

src/workflow/WorkflowManager.py

@@ -18,7 +18,7 @@ def __init__(self, name: str, workspace: str):
         self.workflow_dir = Path(workspace, name.replace(" ", "-").lower())
         self.file_manager = FileManager(self.workflow_dir)
         self.logger = Logger(self.workflow_dir)
-        self.parameter_manager = ParameterManager(self.workflow_dir)
+        self.parameter_manager = ParameterManager(self.workflow_dir, workflow_name=name)
         self.executor = CommandExecutor(self.workflow_dir, self.logger, self.parameter_manager)
         self.ui = StreamlitUI(self.workflow_dir, self.logger, self.executor, self.parameter_manager)
         self.params = self.parameter_manager.get_parameters_from_json()

tests/test_parameter_presets.py

@@ -266,6 +266,56 @@ def test_apply_preset_preserves_existing_params(self, temp_workflow_dir, sample_
         assert saved_params["ToolA"]["param1"] == 10.0
 
 
+class TestWorkflowNameParameter:
+    """Tests for the workflow_name parameter in ParameterManager."""
+
+    def test_workflow_name_defaults_to_directory_stem(self, temp_workflow_dir):
+        """Test that workflow_name defaults to the directory stem when not provided."""
+        pm = ParameterManager(temp_workflow_dir)
+        assert pm.workflow_name == "test-workflow"
+
+    def test_workflow_name_can_be_explicitly_set(self, temp_workflow_dir):
+        """Test that workflow_name can be explicitly set."""
+        pm = ParameterManager(temp_workflow_dir, workflow_name="My Custom Workflow")
+        assert pm.workflow_name == "My Custom Workflow"
+
+    def test_load_presets_normalizes_workflow_name(self, temp_workflow_dir, temp_cwd):
+        """Test that load_presets normalizes the workflow name for lookup."""
+        # Create presets with normalized key
+        presets = {
+            "my-custom-workflow": {
+                "Test Preset": {
+                    "_description": "A test preset"
+                }
+            }
+        }
+        with open("presets.json", "w") as f:
+            json.dump(presets, f)
+
+        # Pass workflow name with spaces and mixed case
+        pm = ParameterManager(temp_workflow_dir, workflow_name="My Custom Workflow")
+        preset_names = pm.get_preset_names()
+
+        assert "Test Preset" in preset_names
+
+    def test_load_presets_with_original_name_format(self, temp_workflow_dir, temp_cwd):
+        """Test that presets can use the same format as WorkflowManager normalization."""
+        # This simulates how WorkflowManager passes the name
+        presets = {
+            "topp-workflow": {
+                "Preset X": {"_description": "Test"}
+            }
+        }
+        with open("presets.json", "w") as f:
+            json.dump(presets, f)
+
+        # Simulating WorkflowManager passing "TOPP Workflow"
+        pm = ParameterManager(temp_workflow_dir, workflow_name="TOPP Workflow")
+        preset_names = pm.get_preset_names()
+
+        assert "Preset X" in preset_names
+
+
 class TestPresetsJsonFormat:
     """Tests for the presets.json format validation."""