Merge branch 'static_assert' into 'master'

Assumeru · Assumeru · commit 5a42db3256f5 · 2025-04-21T08:35:17.000Z
Use static_assert for compile time check

See merge request OpenMW/openmw!4637
diff --git a/apps/openmw/mwworld/containerstore.hpp b/apps/openmw/mwworld/containerstore.hpp
@@ -406,8 +406,7 @@ namespace MWWorld
         template <class T>
         ContainerStoreIteratorBase(const ContainerStoreIteratorBase<T>& other)
         {
-            char CANNOT_CONVERT_CONST_ITERATOR_TO_ITERATOR[IsConvertible<T, PtrType, void>::value ? 1 : -1];
-            ((void)CANNOT_CONVERT_CONST_ITERATOR_TO_ITERATOR);
+            static_assert(IsConvertible<T, PtrType, void>::value);
             copy(other);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -406,8 +406,7 @@ namespace MWWorld`
`406`	`406`	`template <class T>`
`407`	`407`	`ContainerStoreIteratorBase(const ContainerStoreIteratorBase<T>& other)`
`408`	`408`	`{`
`409`		`- char CANNOT_CONVERT_CONST_ITERATOR_TO_ITERATOR[IsConvertible<T, PtrType, void>::value ? 1 : -1];`
`410`		`- ((void)CANNOT_CONVERT_CONST_ITERATOR_TO_ITERATOR);`
	`409`	`+ static_assert(IsConvertible<T, PtrType, void>::value);`
`411`	`410`	`copy(other);`
`412`	`411`	`}`
`413`	`412`