fix macos deprecation warnings

Author: psi29a

CMakeLists.txt

@@ -735,6 +735,7 @@ endif()
 if (APPLE)
     target_compile_definitions(components PRIVATE GL_SILENCE_DEPRECATION=1)
     target_compile_definitions(openmw PRIVATE GL_SILENCE_DEPRECATION=1)
+    target_compile_definitions(openmw-lib PRIVATE GL_SILENCE_DEPRECATION=1)
 endif()
 
 # Apple bundling

apps/opencs/model/prefs/boolsetting.cpp

@@ -34,7 +34,7 @@ CSMPrefs::SettingWidgets CSMPrefs::BoolSetting::makeWidgets(QWidget* parent)
         mWidget->setToolTip(tooltip);
     }
 
-    connect(mWidget, &QCheckBox::stateChanged, this, &BoolSetting::valueChanged);
+    connect(mWidget, &QCheckBox::checkStateChanged, this, &BoolSetting::valueChanged);
 
     return SettingWidgets{ .mLabel = nullptr, .mInput = mWidget };
 }

apps/opencs/model/prefs/shortcutmanager.cpp

@@ -431,7 +431,7 @@ namespace CSMPrefs
         std::make_pair((int)Qt::Key_twosuperior, "twosuperior"),
         std::make_pair((int)Qt::Key_threesuperior, "threesuperior"),
         std::make_pair((int)Qt::Key_acute, "acute"),
-        std::make_pair((int)Qt::Key_mu, "mu"),
+        std::make_pair((int)Qt::Key_micro, "mu"),
         std::make_pair((int)Qt::Key_paragraph, "paragraph"),
         std::make_pair((int)Qt::Key_periodcentered, "periodcentered"),
         std::make_pair((int)Qt::Key_cedilla, "cedilla"),

apps/opencs/view/world/dialoguesubview.cpp

@@ -298,7 +298,7 @@ QWidget* CSVWorld::DialogueDelegateDispatcher::makeEditor(
         }
         else if (qobject_cast<QCheckBox*>(editor))
         {
-            connect(static_cast<QCheckBox*>(editor), &QCheckBox::stateChanged, proxy,
+            connect(static_cast<QCheckBox*>(editor), &QCheckBox::checkStateChanged, proxy,
                 qOverload<>(&DialogueDelegateDispatcherProxy::editorDataCommited));
         }
         else if (qobject_cast<QPlainTextEdit*>(editor))

apps/opencs/view/world/extendedcommandconfigurator.cpp

@@ -130,7 +130,7 @@ void CSVWorld::ExtendedCommandConfigurator::setupCheckBoxes(const std::vector<CS
         for (int i = numTypes - numCheckBoxes; i > 0; --i)
         {
             QCheckBox* checkBox = new QCheckBox(mTypeGroup);
-            connect(checkBox, &QCheckBox::stateChanged, this, &ExtendedCommandConfigurator::checkBoxStateChanged);
+            connect(checkBox, &QCheckBox::checkStateChanged, this, &ExtendedCommandConfigurator::checkBoxStateChanged);
             mTypeCheckBoxes.insert(std::make_pair(checkBox, CSMWorld::UniversalId::Type_None));
         }
     }

apps/opencs/view/world/tablesubview.cpp

@@ -55,7 +55,7 @@ CSVWorld::TableSubView::TableSubView(
         "\nCan be useful in finding the moved or modified"
         "\nobject instance while 3D editing.");
     autoJump->setCheckState(Qt::Unchecked);
-    connect(autoJump, &QCheckBox::stateChanged, mTable, &Table::jumpAfterModChanged);
+    connect(autoJump, &QCheckBox::checkStateChanged, mTable, &Table::jumpAfterModChanged);
     optHLayout->insertWidget(0, autoJump);
     optHLayout->setContentsMargins(QMargins(0, 3, 0, 0));
     mOptions->setLayout(optHLayout);

components/misc/strings/format.hpp

@@ -54,9 +54,9 @@ namespace Misc::StringUtils
             const int size = std::snprintf(nullptr, 0, fmt, argument(args)...);
             if (size < 0)
                 throw std::system_error(errno, std::generic_category(), "Failed to compute resulting string size");
-            // Note: sprintf also writes a trailing null character. We should remove it.
+            // Note: snprintf also writes a trailing null character. We should remove it.
             std::string ret(static_cast<std::size_t>(size) + 1, '\0');
-            if (std::sprintf(ret.data(), fmt, argument(args)...) < 0)
+            if (std::snprintf(ret.data(), ret.size(), fmt, argument(args)...) < 0)
                 throw std::system_error(errno, std::generic_category(), "Failed to format string");
             ret.erase(static_cast<std::size_t>(size));
             return ret;