Better error handling for issues during bulk attribute update (#1434)

woutersamaey · web-flow · commit 0775715595db · 2022-05-30T13:00:15.000+01:00
diff --git a/app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php b/app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php
@@ -190,8 +190,9 @@ public function saveAction()
         catch (Mage_Core_Exception $e) {
             $this->_getSession()->addError($e->getMessage());
         }
-        catch (Exception $e) {
-            $this->_getSession()->addException($e, $this->__('An error occurred while updating the product(s) attributes.'));
+        catch (Throwable $e) {
+            Mage::logException($e);
+            $this->_getSession()->addError($this->__('An error occurred while updating the product(s) attributes.'));
         }
 
         $this->_redirect('*/catalog_product/', array('store'=>$this->_getHelper()->getSelectedStoreId()));

Original file line number	Diff line number	Diff line change
`@@ -190,8 +190,9 @@ public function saveAction()`
`190`	`190`	`catch (Mage_Core_Exception $e) {`
`191`	`191`	`$this->_getSession()->addError($e->getMessage());`
`192`	`192`	`}`
`193`		`- catch (Exception $e) {`
`194`		`- $this->_getSession()->addException($e, $this->__('An error occurred while updating the product(s) attributes.'));`
	`193`	`+ catch (Throwable $e) {`
	`194`	`+ Mage::logException($e);`
	`195`	`+ $this->_getSession()->addError($this->__('An error occurred while updating the product(s) attributes.'));`
`195`	`196`	`}`
`196`	`197`
`197`	`198`	`$this->_redirect('*/catalog_product/', array('store'=>$this->_getHelper()->getSelectedStoreId()));`