Skip to content

Commit 2d403c8

Browse files
luigifabfballiano
authored andcommitted
Reduce getId calls (#2677)
1 parent 6c575af commit 2d403c8

File tree

1 file changed

+6
-5
lines changed
  • app/code/core/Mage/Catalog/Model/Resource/Category

1 file changed

+6
-5
lines changed

app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,9 @@ public function addCollectionData(
144144

145145
$nodeIds = [];
146146
foreach ($this->getNodes() as $node) {
147-
if (!in_array($node->getId(), $exclude)) {
148-
$nodeIds[] = $node->getId();
147+
$id = $node->getId();
148+
if (!in_array($id, $exclude)) {
149+
$nodeIds[] = $id;
149150
}
150151
}
151152
$collection->addIdFilter($nodeIds);
@@ -167,9 +168,9 @@ public function addCollectionData(
167168
$collection->load();
168169

169170
foreach ($collection as $category) {
170-
if ($this->getNodeById($category->getId())) {
171-
$this->getNodeById($category->getId())
172-
->addData($category->getData());
171+
$node = $this->getNodeById($category->getId());
172+
if ($node) {
173+
$node->addData($category->getData());
173174
}
174175
}
175176

0 commit comments

Comments
 (0)