Wrapped WHERE condition in parens in app/code/core/Mage/Rule/Model/Condition/Combine.php (#2965)

mattdavenport · web-flow · commit 4836d1fad01e · 2023-01-21T19:56:52.000Z
diff --git a/app/code/core/Mage/Rule/Model/Condition/Combine.php b/app/code/core/Mage/Rule/Model/Condition/Combine.php
@@ -52,7 +52,7 @@ public function prepareConditionSql()
         $wheres = [];
         foreach ($this->getConditions() as $condition) {
             /** @var Mage_Rule_Model_Condition_Abstract $condition */
-            $wheres[] = $condition->prepareConditionSql();
+            $wheres[] = '(' . $condition->prepareConditionSql() . ')';
         }
 
         if (empty($wheres)) {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function prepareConditionSql()`
`52`	`52`	`$wheres = [];`
`53`	`53`	`foreach ($this->getConditions() as $condition) {`
`54`	`54`	`/** @var Mage_Rule_Model_Condition_Abstract $condition */`
`55`		`- $wheres[] = $condition->prepareConditionSql();`
	`55`	`+ $wheres[] = '(' . $condition->prepareConditionSql() . ')';`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`if (empty($wheres)) {`