PHP8.5: fix null array offset (#5028)

https://github.com/OpenMage/magento-lts/actions/runs/18709139113/job/53353233192

Author: sreichel

app/code/core/Mage/Catalog/Model/Product/Type.php

@@ -51,7 +51,7 @@ class Mage_Catalog_Model_Product_Type
     public static function factory($product, $singleton = false)
     {
         $types = self::getTypes();
-        $typeId = $product->getTypeId();
+        $typeId = (string) $product->getTypeId();
 
         if (!empty($types[$typeId]['model'])) {
             $typeModelName = $types[$typeId]['model'];

app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php

@@ -309,6 +309,10 @@ public function reindexProductIds($ids)
      */
     protected function _getIndexer($productTypeId)
     {
+        if ($productTypeId === null) {
+            $productTypeId = '';
+        }
+
         $types = $this->getTypeIndexers();
         if (!isset($types[$productTypeId])) {
             Mage::throwException(Mage::helper('catalog')->__('Unsupported product type "%s".', $productTypeId));

app/code/core/Mage/CatalogInventory/Model/Stock/Status.php

@@ -182,7 +182,7 @@ public function assignProduct(Mage_Catalog_Model_Product $product, $stockId = 1,
         if (is_null($stockStatus)) {
             $websiteId = $product->getStore()->getWebsiteId();
             $status = $this->getProductStatus($product->getId(), $websiteId, $stockId);
-            $stockStatus = $status[$product->getId()] ?? null;
+            $stockStatus = $status[(string) $product->getId()] ?? null;
         }
 
         $product->setIsSalable($stockStatus);

app/code/core/Mage/Core/Controller/Varien/Router/Standard.php

@@ -406,7 +406,7 @@ public function getModuleByName($moduleName, $modules)
      */
     public function getFrontNameByRoute($routeName)
     {
-        return $this->_routes[$routeName] ?? false;
+        return $this->_routes[(string) $routeName] ?? false;
     }
 
     /**

app/code/core/Mage/Index/Model/Indexer/Abstract.php

@@ -110,6 +110,10 @@ public function matchEvent(Mage_Index_Model_Event $event)
      */
     public function matchEntityAndType($entity, $type)
     {
+        if ($entity === null) {
+            $entity = '';
+        }
+
         if (isset($this->_matchedEntities[$entity])) {
             if (in_array($type, $this->_matchedEntities[$entity])) {
                 return true;

lib/Varien/Data/Collection.php

@@ -739,6 +739,11 @@ protected function _toOptionHash($valueField = 'id', $labelField = 'name')
     public function getItemById($idValue)
     {
         $this->load();
+
+        if ($idValue === null) {
+            $idValue = '';
+        }
+
         return $this->_items[$idValue] ?? null;
     }
 

lib/Varien/Http/Adapter/Curl.php

@@ -216,7 +216,6 @@ public function read()
      */
     public function close()
     {
-        curl_close($this->_getResource());
         $this->_resource = null;
         return $this;
     }