Refactor legacy usage of implode (#1938)

elidrissidev · web-flow · commit 54dca10a5cb5 · 2021-12-29T10:22:43.000+01:00
diff --git a/app/code/core/Mage/Api2/Model/Renderer/Xml.php b/app/code/core/Mage/Api2/Model/Renderer/Xml.php
@@ -105,7 +105,7 @@ protected function _prepareData($data, $root = false)
             }
         }
         $data = $data instanceof Varien_Object ? $data->toArray() : (array)$data;
-        $isAssoc = !preg_match('/^\d+$/', implode(array_keys($data), ''));
+        $isAssoc = !preg_match('/^\d+$/', implode('', array_keys($data)));
 
         $preparedData = array();
         foreach ($data as $key => $value) {

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ protected function _prepareData($data, $root = false)`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`	`$data = $data instanceof Varien_Object ? $data->toArray() : (array)$data;`
`108`		`- $isAssoc = !preg_match('/^\d+$/', implode(array_keys($data), ''));`
	`108`	`+ $isAssoc = !preg_match('/^\d+$/', implode('', array_keys($data)));`
`109`	`109`
`110`	`110`	`$preparedData = array();`
`111`	`111`	`foreach ($data as $key => $value) {`