phpstan: fix comparison for get_object_vars (#5271)

Author: sreichel

.phpstan.dist.baseline.neon

@@ -3300,36 +3300,12 @@ parameters:
 			count: 4
 			path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api.php
 
-		-
-			rawMessage: 'Strict comparison using !== between array<string, mixed> and null will always evaluate to true.'
-			identifier: notIdentical.alwaysTrue
-			count: 2
-			path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php
-
-		-
-			rawMessage: Unreachable statement - code above always terminates.
-			identifier: deadCode.unreachable
-			count: 1
-			path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php
-
 		-
 			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
 			identifier: empty.notAllowed
 			count: 4
 			path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api.php
 
-		-
-			rawMessage: 'Strict comparison using !== between array<string, mixed> and null will always evaluate to true.'
-			identifier: notIdentical.alwaysTrue
-			count: 1
-			path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php
-
-		-
-			rawMessage: Unreachable statement - code above always terminates.
-			identifier: deadCode.unreachable
-			count: 1
-			path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php
-
 		-
 			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
 			identifier: empty.notAllowed
@@ -4458,18 +4434,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Customer/Model/Customer.php
 
-		-
-			rawMessage: 'Strict comparison using !== between array<string, mixed> and null will always evaluate to true.'
-			identifier: notIdentical.alwaysTrue
-			count: 1
-			path: app/code/core/Mage/Customer/Model/Customer/Api/V2.php
-
-		-
-			rawMessage: Unreachable statement - code above always terminates.
-			identifier: deadCode.unreachable
-			count: 1
-			path: app/code/core/Mage/Customer/Model/Customer/Api/V2.php
-
 		-
 			rawMessage: 'Construct empty() is not allowed. Use more strict comparison.'
 			identifier: empty.notAllowed
@@ -7584,6 +7548,12 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Weee/Model/Tax.php
 
+		-
+			rawMessage: If condition is always false.
+			identifier: if.alwaysFalse
+			count: 1
+			path: app/code/core/Mage/Weee/Model/Total/Quote/Weee.php
+
 		-
 			rawMessage: PHPDoc type Mage_Weee_Helper_Data of property Mage_Weee_Model_Total_Quote_Weee::$_helper is not the same as PHPDoc type Mage_Tax_Helper_Data of overridden property Mage_Tax_Model_Sales_Total_Quote_Tax::$_helper.
 			identifier: property.phpDocType

app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php

@@ -22,7 +22,7 @@ class Mage_Checkout_Model_Cart_Customer_Api_V2 extends Mage_Checkout_Model_Cart_
      */
     protected function _prepareCustomerData($data)
     {
-        if (($_data = get_object_vars($data)) !== null) {
+        if (($_data = get_object_vars($data)) !== []) {
             return parent::_prepareCustomerData($_data);
         }
 
@@ -40,7 +40,7 @@ protected function _prepareCustomerAddressData($data)
         if (is_array($data)) {
             $dataAddresses = [];
             foreach ($data as $addressItem) {
-                if (($_addressItem = get_object_vars($addressItem)) !== null) {
+                if (($_addressItem = get_object_vars($addressItem)) !== []) {
                     $dataAddresses[] = $_addressItem;
                 }
             }

app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php

@@ -20,7 +20,7 @@ class Mage_Checkout_Model_Cart_Payment_Api_V2 extends Mage_Checkout_Model_Cart_P
      */
     protected function _preparePaymentData($data)
     {
-        if (($_data = get_object_vars($data)) !== null) {
+        if (($_data = get_object_vars($data)) !== []) {
             return parent::_preparePaymentData($_data);
         }
 

app/code/core/Mage/Customer/Model/Customer/Api/V2.php

@@ -23,7 +23,7 @@ class Mage_Customer_Model_Customer_Api_V2 extends Mage_Customer_Model_Customer_A
      */
     protected function _prepareData($data)
     {
-        if (($objectVars = get_object_vars($data)) !== null) {
+        if (($objectVars = get_object_vars($data)) !== []) {
             return parent::_prepareData($objectVars);
         }