Skip to content

Commit 5d9036e

Browse files
eneiasramoseneiasramos
authored
Bugfix to avoid newline character in customFormSubmit URL (#2518)
1 parent 4db847a commit 5d9036e

File tree

3 files changed

+12
-24
lines changed

3 files changed

+12
-24
lines changed

‎app/design/frontend/base/default/template/catalog/product/list.phtml‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,11 @@
5555
<?php echo $this->getPriceHtml($_product, true) ?>
5656
<?php if($_product->isSaleable()): ?>
5757
<p class="action">
58+
<?php $_cartUrl = $this->getAddToCartUrlCustom($_product, [], false); ?>
5859
<button type="button"
5960
title="<?php echo $this->quoteEscape($this->__('Add to Cart')) ?>"
6061
class="button btn-cart"
61-
onclick="customFormSubmit(
62-
'<?php echo $this->getAddToCartUrlCustom($_product, [], false) ?>',
63-
'<?php echo $_params ?>',
64-
'post')">
62+
onclick="customFormSubmit('<?php echo $_cartUrl ?>', '<?php echo $_params ?>', 'post')">
6563
<span><span><?php echo $this->__('Add to Cart') ?></span></span>
6664
</button>
6765
</p>
@@ -122,13 +120,11 @@
122120
<?php echo $this->getPriceHtml($_product, true) ?>
123121
<div class="actions">
124122
<?php if($_product->isSaleable()): ?>
123+
<?php $_cartUrl = $this->getAddToCartUrlCustom($_product, [], false); ?>
125124
<button type="button"
126125
title="<?php echo $this->quoteEscape($this->__('Add to Cart')) ?>"
127126
class="button btn-cart"
128-
onclick="customFormSubmit(
129-
'<?php echo $this->getAddToCartUrlCustom($_product, [], false) ?>',
130-
'<?php echo $_params ?>',
131-
'post')">
127+
onclick="customFormSubmit('<?php echo $_cartUrl ?>', '<?php echo $_params ?>', 'post')">
132128
<span><span><?php echo $this->__('Add to Cart') ?></span></span>
133129
</button>
134130
<?php else: ?>

‎app/design/frontend/rwd/default/template/catalog/product/list.phtml‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,11 @@
8484
<div class="product-secondary">
8585
<?php if(!$_product->canConfigure() && $_product->isSaleable()): ?>
8686
<p class="action">
87+
<?php $_cartUrl = $this->getAddToCartUrlCustom($_product, [], false); ?>
8788
<button type="button"
8889
title="<?php echo $this->quoteEscape($this->__('Add to Cart')) ?>"
8990
class="button btn-cart"
90-
onclick="customFormSubmit(
91-
'<?php echo $this->getAddToCartUrlCustom($_product, [], false) ?>',
92-
'<?php echo $_params ?>',
93-
'post')">
91+
onclick="customFormSubmit('<?php echo $_cartUrl ?>', '<?php echo $_params ?>', 'post')">
9492
<span><span><?php echo $this->__('Add to Cart') ?></span></span>
9593
</button>
9694
</p>
@@ -172,13 +170,11 @@
172170
<?php endif ?>
173171
<div class="actions">
174172
<?php if(!$_product->canConfigure() && $_product->isSaleable()): ?>
173+
<?php $_cartUrl = $this->getAddToCartUrlCustom($_product, [], false); ?>
175174
<button type="button"
176175
title="<?php echo $this->quoteEscape($this->__('Add to Cart')) ?>"
177176
class="button btn-cart"
178-
onclick="customFormSubmit(
179-
'<?php echo $this->getAddToCartUrlCustom($_product, [], false) ?>',
180-
'<?php echo $_params ?>',
181-
'post')">
177+
onclick="customFormSubmit('<?php echo $_cartUrl ?>', '<?php echo $_params ?>', 'post')">
182178
<span><span><?php echo $this->__('Add to Cart') ?></span></span>
183179
</button>
184180
<?php elseif($_product->getStockItem() && $_product->getStockItem()->getIsInStock()): ?>

‎app/design/frontend/rwd/default/template/email/catalog/product/list.phtml‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,11 @@ $_params = $this->escapeHtml(json_encode(['form_key' => $this->getFormKey()]));
8484
<div class="product-secondary">
8585
<?php if(!$_product->canConfigure() && $_product->isSaleable()): ?>
8686
<p class="action">
87+
<?php $_cartUrl = $this->getAddToCartUrlCustom($_product, [], false); ?>
8788
<button type="button"
8889
title="<?php echo $this->quoteEscape($this->__('Add to Cart')) ?>"
8990
class="button btn-cart"
90-
onclick="customFormSubmit(
91-
'<?php echo $this->getAddToCartUrlCustom($_product, [], false) ?>',
92-
'<?php echo $_params ?>',
93-
'post')">
91+
onclick="customFormSubmit('<?php echo $_cartUrl ?>', '<?php echo $_params ?>', 'post')">
9492
<span><span><?php echo $this->__('Add to Cart') ?></span></span>
9593
</button>
9694
</p>
@@ -170,13 +168,11 @@ $_params = $this->escapeHtml(json_encode(['form_key' => $this->getFormKey()]));
170168
<?php endif ?>
171169
<div class="actions">
172170
<?php if(!$_product->canConfigure() && $_product->isSaleable()): ?>
171+
<?php $_cartUrl = $this->getAddToCartUrlCustom($_product, [], false); ?>
173172
<button type="button"
174173
title="<?php echo $this->quoteEscape($this->__('Add to Cart')) ?>"
175174
class="button btn-cart"
176-
onclick="customFormSubmit(
177-
'<?php echo $this->getAddToCartUrlCustom($_product, [], false) ?>',
178-
'<?php echo $_params ?>',
179-
'post')">
175+
onclick="customFormSubmit('<?php echo $_cartUrl ?>', '<?php echo $_params ?>', 'post')">
180176
<span><span><?php echo $this->__('Add to Cart') ?></span></span>
181177
</button>
182178
<?php elseif($_product->getStockItem() && $_product->getStockItem()->getIsInStock()): ?>

0 commit comments

Comments
 (0)