Skip to content

Commit 71157d9

Browse files
committed
Fix #1216 and the fallback theme
1 parent 24cd60d commit 71157d9

File tree

776 files changed

+174
-76
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

776 files changed

+174
-76
lines changed

.phpstan.dist.baseline.neon

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -5188,235 +5188,235 @@ parameters:
51885188
rawMessage: 'Call to an undefined method Mage_Core_Block_Abstract::_getUsers().'
51895189
identifier: method.notFound
51905190
count: 1
5191-
path: app/design/adminhtml/default/default/template/api/role_users_grid_js.phtml
5191+
path: app/design/adminhtml/base/default/template/api/role_users_grid_js.phtml
51925192

51935193
-
51945194
rawMessage: 'Call to protected method _getGridHtml() of class Mage_Adminhtml_Block_Api_Tab_Rolesusers.'
51955195
identifier: method.protected
51965196
count: 1
5197-
path: app/design/adminhtml/default/default/template/api/rolesusers.phtml
5197+
path: app/design/adminhtml/base/default/template/api/rolesusers.phtml
51985198

51995199
-
52005200
rawMessage: 'Call to an undefined method Mage_Core_Block_Abstract::_getSelectedRoles().'
52015201
identifier: method.notFound
52025202
count: 1
5203-
path: app/design/adminhtml/default/default/template/api/user_roles_grid_js.phtml
5203+
path: app/design/adminhtml/base/default/template/api/user_roles_grid_js.phtml
52045204

52055205
-
52065206
rawMessage: 'Call to protected method _isSelected() of class Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option.'
52075207
identifier: method.protected
52085208
count: 1
5209-
path: app/design/adminhtml/default/default/template/bundle/product/composite/fieldset/options/type/checkbox.phtml
5209+
path: app/design/adminhtml/base/default/template/bundle/product/composite/fieldset/options/type/checkbox.phtml
52105210

52115211
-
52125212
rawMessage: 'Call to protected method _isSelected() of class Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option.'
52135213
identifier: method.protected
52145214
count: 1
5215-
path: app/design/adminhtml/default/default/template/bundle/product/composite/fieldset/options/type/multi.phtml
5215+
path: app/design/adminhtml/base/default/template/bundle/product/composite/fieldset/options/type/multi.phtml
52165216

52175217
-
52185218
rawMessage: 'Call to protected method _getDefaultValues() of class Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option.'
52195219
identifier: method.protected
52205220
count: 1
5221-
path: app/design/adminhtml/default/default/template/bundle/product/composite/fieldset/options/type/radio.phtml
5221+
path: app/design/adminhtml/base/default/template/bundle/product/composite/fieldset/options/type/radio.phtml
52225222

52235223
-
52245224
rawMessage: 'Call to protected method _isSelected() of class Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option.'
52255225
identifier: method.protected
52265226
count: 1
5227-
path: app/design/adminhtml/default/default/template/bundle/product/composite/fieldset/options/type/radio.phtml
5227+
path: app/design/adminhtml/base/default/template/bundle/product/composite/fieldset/options/type/radio.phtml
52285228

52295229
-
52305230
rawMessage: 'Call to protected method _showSingle() of class Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option.'
52315231
identifier: method.protected
52325232
count: 1
5233-
path: app/design/adminhtml/default/default/template/bundle/product/composite/fieldset/options/type/radio.phtml
5233+
path: app/design/adminhtml/base/default/template/bundle/product/composite/fieldset/options/type/radio.phtml
52345234

52355235
-
52365236
rawMessage: 'Call to protected method _getDefaultValues() of class Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option.'
52375237
identifier: method.protected
52385238
count: 1
5239-
path: app/design/adminhtml/default/default/template/bundle/product/composite/fieldset/options/type/select.phtml
5239+
path: app/design/adminhtml/base/default/template/bundle/product/composite/fieldset/options/type/select.phtml
52405240

52415241
-
52425242
rawMessage: 'Call to protected method _isSelected() of class Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option.'
52435243
identifier: method.protected
52445244
count: 1
5245-
path: app/design/adminhtml/default/default/template/bundle/product/composite/fieldset/options/type/select.phtml
5245+
path: app/design/adminhtml/base/default/template/bundle/product/composite/fieldset/options/type/select.phtml
52465246

52475247
-
52485248
rawMessage: 'Call to protected method _showSingle() of class Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option.'
52495249
identifier: method.protected
52505250
count: 1
5251-
path: app/design/adminhtml/default/default/template/bundle/product/composite/fieldset/options/type/select.phtml
5251+
path: app/design/adminhtml/base/default/template/bundle/product/composite/fieldset/options/type/select.phtml
52525252

52535253
-
52545254
rawMessage: 'Call to protected method _getHeader() of class Mage_Adminhtml_Block_Catalog_Product_Attribute_Set_Main.'
52555255
identifier: method.protected
52565256
count: 1
5257-
path: app/design/adminhtml/default/default/template/catalog/product/attribute/set/main.phtml
5257+
path: app/design/adminhtml/base/default/template/catalog/product/attribute/set/main.phtml
52585258

52595259
-
52605260
rawMessage: 'Call to protected method _getHeader() of class Mage_Adminhtml_Block_Catalog_Product_Attribute_Set_Toolbar_Add.'
52615261
identifier: method.protected
52625262
count: 1
5263-
path: app/design/adminhtml/default/default/template/catalog/product/attribute/set/toolbar/add.phtml
5263+
path: app/design/adminhtml/base/default/template/catalog/product/attribute/set/toolbar/add.phtml
52645264

52655265
-
52665266
rawMessage: 'Call to protected method _getHeader() of class Mage_Adminhtml_Block_Catalog_Product_Attribute_Set_Toolbar_Main.'
52675267
identifier: method.protected
52685268
count: 1
5269-
path: app/design/adminhtml/default/default/template/catalog/product/attribute/set/toolbar/main.phtml
5269+
path: app/design/adminhtml/base/default/template/catalog/product/attribute/set/toolbar/main.phtml
52705270

52715271
-
52725272
rawMessage: Access to an undefined property Mage_Catalog_Model_Product_Option::$decoratedIsLast.
52735273
identifier: property.notFound
52745274
count: 1
5275-
path: app/design/adminhtml/default/default/template/catalog/product/composite/fieldset/options/type/date.phtml
5275+
path: app/design/adminhtml/base/default/template/catalog/product/composite/fieldset/options/type/date.phtml
52765276

52775277
-
52785278
rawMessage: Access to an undefined property Mage_Catalog_Model_Product_Option::$decoratedIsLast.
52795279
identifier: property.notFound
52805280
count: 1
5281-
path: app/design/adminhtml/default/default/template/catalog/product/composite/fieldset/options/type/file.phtml
5281+
path: app/design/adminhtml/base/default/template/catalog/product/composite/fieldset/options/type/file.phtml
52825282

52835283
-
52845284
rawMessage: Access to an undefined property Mage_Catalog_Model_Product_Option::$decoratedIsLast.
52855285
identifier: property.notFound
52865286
count: 1
5287-
path: app/design/adminhtml/default/default/template/catalog/product/composite/fieldset/options/type/select.phtml
5287+
path: app/design/adminhtml/base/default/template/catalog/product/composite/fieldset/options/type/select.phtml
52885288

52895289
-
52905290
rawMessage: Access to an undefined property Mage_Catalog_Model_Product_Option::$decoratedIsLast.
52915291
identifier: property.notFound
52925292
count: 1
5293-
path: app/design/adminhtml/default/default/template/catalog/product/composite/fieldset/options/type/text.phtml
5293+
path: app/design/adminhtml/base/default/template/catalog/product/composite/fieldset/options/type/text.phtml
52945294

52955295
-
52965296
rawMessage: 'Parameter #2 $store of method Mage_Core_Helper_Data::currencyByStore() expects int|Mage_Core_Model_Store|null, true given.'
52975297
identifier: argument.type
52985298
count: 1
5299-
path: app/design/adminhtml/default/default/template/catalog/product/price.phtml
5299+
path: app/design/adminhtml/base/default/template/catalog/product/price.phtml
53005300

53015301
-
53025302
rawMessage: 'Call to an undefined method Mage_GiftMessage_Block_Message_Helper::prepareAsIs().'
53035303
identifier: method.notFound
53045304
count: 2
5305-
path: app/design/adminhtml/default/default/template/giftmessage/helper.phtml
5305+
path: app/design/adminhtml/base/default/template/giftmessage/helper.phtml
53065306

53075307
-
53085308
rawMessage: 'Parameter #1 $value of method Mage_GiftMessage_Block_Message_Helper::setScriptIncluded() expects string, true given.'
53095309
identifier: argument.type
53105310
count: 1
5311-
path: app/design/adminhtml/default/default/template/giftmessage/helper.phtml
5311+
path: app/design/adminhtml/base/default/template/giftmessage/helper.phtml
53125312

53135313
-
53145314
rawMessage: 'Call to an undefined method Mage_Core_Block_Abstract::_getUsers().'
53155315
identifier: method.notFound
53165316
count: 1
5317-
path: app/design/adminhtml/default/default/template/permissions/role_users_grid_js.phtml
5317+
path: app/design/adminhtml/base/default/template/permissions/role_users_grid_js.phtml
53185318

53195319
-
53205320
rawMessage: 'Call to protected method _getGridHtml() of class Mage_Adminhtml_Block_Permissions_Tab_Rolesusers.'
53215321
identifier: method.protected
53225322
count: 1
5323-
path: app/design/adminhtml/default/default/template/permissions/rolesusers.phtml
5323+
path: app/design/adminhtml/base/default/template/permissions/rolesusers.phtml
53245324

53255325
-
53265326
rawMessage: 'Call to an undefined method Mage_Core_Block_Abstract::_getSelectedRoles().'
53275327
identifier: method.notFound
53285328
count: 1
5329-
path: app/design/adminhtml/default/default/template/permissions/user_roles_grid_js.phtml
5329+
path: app/design/adminhtml/base/default/template/permissions/user_roles_grid_js.phtml
53305330

53315331
-
53325332
rawMessage: 'Comparison operation ">" between int<1, max> and 0 is always true.'
53335333
identifier: greater.alwaysTrue
53345334
count: 1
5335-
path: app/design/adminhtml/default/default/template/report/grid.phtml
5335+
path: app/design/adminhtml/base/default/template/report/grid.phtml
53365336

53375337
-
53385338
rawMessage: 'Method Mage_Adminhtml_Block_Sales_Order_Create_Abstract::formatPrice() invoked with 3 parameters, 1 required.'
53395339
identifier: arguments.count
53405340
count: 18
5341-
path: app/design/adminhtml/default/default/template/sales/order/create/items/grid.phtml
5341+
path: app/design/adminhtml/base/default/template/sales/order/create/items/grid.phtml
53425342

53435343
-
53445344
rawMessage: Access to an undefined property Mage_Adminhtml_Block_Sales_Order_Shipment_Tracking_Info::$trackingInfo.
53455345
identifier: property.notFound
53465346
count: 1
5347-
path: app/design/adminhtml/default/default/template/sales/order/shipment/tracking/info.phtml
5347+
path: app/design/adminhtml/base/default/template/sales/order/shipment/tracking/info.phtml
53485348

53495349
-
53505350
rawMessage: Access to protected property Mage_Adminhtml_Block_System_Config_Form_Field_Regexceptions|Mage_CatalogInventory_Block_Adminhtml_Form_Field_Minsaleqty::$_addAfter.
53515351
identifier: property.protected
53525352
count: 3
5353-
path: app/design/adminhtml/default/default/template/system/config/form/field/array.phtml
5353+
path: app/design/adminhtml/base/default/template/system/config/form/field/array.phtml
53545354

53555355
-
53565356
rawMessage: Access to protected property Mage_Adminhtml_Block_System_Config_Form_Field_Regexceptions|Mage_CatalogInventory_Block_Adminhtml_Form_Field_Minsaleqty::$_addButtonLabel.
53575357
identifier: property.protected
53585358
count: 2
5359-
path: app/design/adminhtml/default/default/template/system/config/form/field/array.phtml
5359+
path: app/design/adminhtml/base/default/template/system/config/form/field/array.phtml
53605360

53615361
-
53625362
rawMessage: Access to protected property Mage_Adminhtml_Block_System_Config_Form_Field_Regexceptions|Mage_CatalogInventory_Block_Adminhtml_Form_Field_Minsaleqty::$_columns.
53635363
identifier: property.protected
53645364
count: 4
5365-
path: app/design/adminhtml/default/default/template/system/config/form/field/array.phtml
5365+
path: app/design/adminhtml/base/default/template/system/config/form/field/array.phtml
53665366

53675367
-
53685368
rawMessage: 'Call to protected method _renderCellTemplate() of class Mage_Adminhtml_Block_System_Config_Form_Field_Array_Abstract.'
53695369
identifier: method.protected
53705370
count: 1
5371-
path: app/design/adminhtml/default/default/template/system/config/form/field/array.phtml
5371+
path: app/design/adminhtml/base/default/template/system/config/form/field/array.phtml
53725372

53735373
-
53745374
rawMessage: Access to protected property Mage_Adminhtml_Block_System_Config_Form_Field_Csp_Hosts::$_addAfter.
53755375
identifier: property.protected
53765376
count: 4
5377-
path: app/design/adminhtml/default/default/template/system/config/form/field/csp.phtml
5377+
path: app/design/adminhtml/base/default/template/system/config/form/field/csp.phtml
53785378

53795379
-
53805380
rawMessage: Access to protected property Mage_Adminhtml_Block_System_Config_Form_Field_Csp_Hosts::$_addButtonLabel.
53815381
identifier: property.protected
53825382
count: 2
5383-
path: app/design/adminhtml/default/default/template/system/config/form/field/csp.phtml
5383+
path: app/design/adminhtml/base/default/template/system/config/form/field/csp.phtml
53845384

53855385
-
53865386
rawMessage: Access to protected property Mage_Adminhtml_Block_System_Config_Form_Field_Csp_Hosts::$_columns.
53875387
identifier: property.protected
53885388
count: 5
5389-
path: app/design/adminhtml/default/default/template/system/config/form/field/csp.phtml
5389+
path: app/design/adminhtml/base/default/template/system/config/form/field/csp.phtml
53905390

53915391
-
53925392
rawMessage: 'Call to protected method _renderCellTemplate() of class Mage_Adminhtml_Block_System_Config_Form_Field_Csp_Hosts.'
53935393
identifier: method.protected
53945394
count: 2
5395-
path: app/design/adminhtml/default/default/template/system/config/form/field/csp.phtml
5395+
path: app/design/adminhtml/base/default/template/system/config/form/field/csp.phtml
53965396

53975397
-
53985398
rawMessage: Negated boolean expression is always true.
53995399
identifier: booleanNot.alwaysTrue
54005400
count: 2
5401-
path: app/design/adminhtml/default/default/template/system/store/tree.phtml
5401+
path: app/design/adminhtml/base/default/template/system/store/tree.phtml
54025402

54035403
-
54045404
rawMessage: 'Method Mage_Adminhtml_Block_Widget_Grid::getEmptyCellColspan() invoked with 1 parameter, 0 required.'
54055405
identifier: arguments.count
54065406
count: 1
5407-
path: app/design/adminhtml/default/default/template/widget/grid.phtml
5407+
path: app/design/adminhtml/base/default/template/widget/grid.phtml
54085408

54095409
-
54105410
rawMessage: 'Method Mage_Adminhtml_Block_Widget_Grid::getMultipleRowColumns() invoked with 1 parameter, 0 required.'
54115411
identifier: arguments.count
54125412
count: 1
5413-
path: app/design/adminhtml/default/default/template/widget/grid.phtml
5413+
path: app/design/adminhtml/base/default/template/widget/grid.phtml
54145414

54155415
-
54165416
rawMessage: 'Call to an undefined method Mage_Adminhtml_Block_Widget_Grid_Massaction::canDisplayContainer().'
54175417
identifier: method.notFound
54185418
count: 1
5419-
path: app/design/adminhtml/default/default/template/widget/grid/massaction.phtml
5419+
path: app/design/adminhtml/base/default/template/widget/grid/massaction.phtml
54205420

54215421
-
54225422
rawMessage: 'Method Mage_Catalog_Block_Product_Abstract::getTierPrices() invoked with 2 parameters, 0-1 required.'

.phpstan.dist.neon

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -77,33 +77,33 @@ parameters:
7777
# @todo add classes to widgets
7878
message: '#^Variable \$this might not be defined\.$#'
7979
paths:
80-
- app/design/adminhtml/default/default/template/api/usernroles.phtml
81-
- app/design/adminhtml/default/default/template/dashboard/searches.phtml
82-
- app/design/adminhtml/default/default/template/dashboard/store/switcher.phtml
83-
- app/design/adminhtml/default/default/template/empty.phtml
84-
- app/design/adminhtml/default/default/template/overlay_popup.phtml
85-
- app/design/adminhtml/default/default/template/popup.phtml
86-
- app/design/adminhtml/default/default/template/promo/form.phtml
87-
- app/design/adminhtml/default/default/template/rating/stars/detailed.phtml
88-
- app/design/adminhtml/default/default/template/review/add.phtml
89-
- app/design/adminhtml/default/default/template/sales/billing/agreement/form.phtml
90-
- app/design/adminhtml/default/default/template/sales/items/renderer/default.phtml
91-
- app/design/adminhtml/default/default/template/sales/order/shipment/create/items/renderer/configurable.phtml
92-
- app/design/adminhtml/default/default/template/sales/order/totals/discount.phtml
93-
- app/design/adminhtml/default/default/template/sales/order/totals/due.phtml
94-
- app/design/adminhtml/default/default/template/sales/order/totals/footer.phtml
95-
- app/design/adminhtml/default/default/template/sales/order/totals/grand.phtml
96-
- app/design/adminhtml/default/default/template/sales/order/totals/item.phtml
97-
- app/design/adminhtml/default/default/template/sales/order/totals/main.phtml
98-
- app/design/adminhtml/default/default/template/sales/order/totals/paid.phtml
99-
- app/design/adminhtml/default/default/template/sales/order/totals/refunded.phtml
100-
- app/design/adminhtml/default/default/template/sales/order/totals/shipping.phtml
101-
- app/design/adminhtml/default/default/template/sales/order/totals/subtotal.phtml
102-
- app/design/adminhtml/default/default/template/sales/order/view/tracking.phtml
103-
- app/design/adminhtml/default/default/template/system/info.phtml
104-
- app/design/adminhtml/default/default/template/tax/class/page/edit.phtml
105-
- app/design/adminhtml/default/default/template/tax/toolbar/class/save.phtml
106-
- app/design/adminhtml/default/default/template/tax/toolbar/rule/save.phtml
80+
- app/design/adminhtml/base/default/template/api/usernroles.phtml
81+
- app/design/adminhtml/base/default/template/dashboard/searches.phtml
82+
- app/design/adminhtml/base/default/template/dashboard/store/switcher.phtml
83+
- app/design/adminhtml/base/default/template/empty.phtml
84+
- app/design/adminhtml/base/default/template/overlay_popup.phtml
85+
- app/design/adminhtml/base/default/template/popup.phtml
86+
- app/design/adminhtml/base/default/template/promo/form.phtml
87+
- app/design/adminhtml/base/default/template/rating/stars/detailed.phtml
88+
- app/design/adminhtml/base/default/template/review/add.phtml
89+
- app/design/adminhtml/base/default/template/sales/billing/agreement/form.phtml
90+
- app/design/adminhtml/base/default/template/sales/items/renderer/default.phtml
91+
- app/design/adminhtml/base/default/template/sales/order/shipment/create/items/renderer/configurable.phtml
92+
- app/design/adminhtml/base/default/template/sales/order/totals/discount.phtml
93+
- app/design/adminhtml/base/default/template/sales/order/totals/due.phtml
94+
- app/design/adminhtml/base/default/template/sales/order/totals/footer.phtml
95+
- app/design/adminhtml/base/default/template/sales/order/totals/grand.phtml
96+
- app/design/adminhtml/base/default/template/sales/order/totals/item.phtml
97+
- app/design/adminhtml/base/default/template/sales/order/totals/main.phtml
98+
- app/design/adminhtml/base/default/template/sales/order/totals/paid.phtml
99+
- app/design/adminhtml/base/default/template/sales/order/totals/refunded.phtml
100+
- app/design/adminhtml/base/default/template/sales/order/totals/shipping.phtml
101+
- app/design/adminhtml/base/default/template/sales/order/totals/subtotal.phtml
102+
- app/design/adminhtml/base/default/template/sales/order/view/tracking.phtml
103+
- app/design/adminhtml/base/default/template/system/info.phtml
104+
- app/design/adminhtml/base/default/template/tax/class/page/edit.phtml
105+
- app/design/adminhtml/base/default/template/tax/toolbar/class/save.phtml
106+
- app/design/adminhtml/base/default/template/tax/toolbar/rule/save.phtml
107107
- app/design/frontend/base/default/template/bundle/catalog/product/list/partof.phtml
108108
- app/design/frontend/base/default/template/bundle/catalog/product/view/options/notice.phtml
109109
- app/design/frontend/base/default/template/catalog/category/page.phtml

0 commit comments

Comments
 (0)