Skip to content

Commit 81786ed

Browse files
authored
Bug: Call to function is_array() with bool (#5098)
1 parent eede9bd commit 81786ed

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

.phpstan.dist.baseline.neon

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2382,12 +2382,6 @@ parameters:
23822382
count: 2
23832383
path: app/code/core/Mage/Log/Model/Resource/Log.php
23842384

2385-
-
2386-
rawMessage: 'Call to function is_null() with bool will always evaluate to false.'
2387-
identifier: function.impossibleType
2388-
count: 1
2389-
path: app/code/core/Mage/Newsletter/Model/Subscriber.php
2390-
23912385
-
23922386
rawMessage: 'Call to function is_null() with Mage_Newsletter_Model_Queue will always evaluate to false.'
23932387
identifier: function.impossibleType

app/code/core/Mage/Newsletter/Model/Subscriber.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ public function subscribeCustomer($customer)
469469

470470
$this->save();
471471
$sendSubscription = $customer->getData('sendSubscription') || $sendInformationEmail;
472-
if (is_null($sendSubscription) xor $sendSubscription) {
472+
if ($sendSubscription) {
473473
if ($this->getIsStatusChanged() && $status == self::STATUS_UNSUBSCRIBED) {
474474
$this->sendUnsubscriptionEmail();
475475
} elseif ($this->getIsStatusChanged() && $status == self::STATUS_SUBSCRIBED) {

0 commit comments

Comments
 (0)