feat?: backend: do not log on invalid stores - creates infinite loop

Author: Pascal Querner

app/code/core/Mage/Core/Helper/EnvironmentConfigLoader.php

@@ -50,6 +50,10 @@ class Mage_Core_Helper_EnvironmentConfigLoader extends Mage_Core_Helper_Abstract
      */
     public function overrideEnvironment(Varien_Simplexml_Config $xmlConfig)
     {
+        $data = Mage::registry('current_env_config');
+        if ($data) {
+            return;
+        }
         $env = $this->getEnv();
 
         foreach ($env as $configKey => $value) {
@@ -71,7 +75,7 @@ public function overrideEnvironment(Varien_Simplexml_Config $xmlConfig)
                             $this->setCache($store, $value, $path);
                         }
                     } catch (Throwable $exception) {
-                        Mage::logException($exception);
+                        // invalid store, intentionally empty
                     }
                     break;
 
@@ -91,15 +95,20 @@ public function overrideEnvironment(Varien_Simplexml_Config $xmlConfig)
                             }
                         }
                     } catch (Throwable $exception) {
-                        Mage::logException($exception);
+                        // invalid store, intentionally empty
                     }
                     break;
             }
         }
+        Mage::register("current_env_config", true, true);
     }
 
     public function hasPath(string $wantedPath): bool
     {
+        $data = Mage::registry("config_env_has_path_$wantedPath");
+        if ($data !== null) {
+            return $data;
+        }
         $env = $this->getEnv();
         $config = [];
 
@@ -127,11 +136,17 @@ public function hasPath(string $wantedPath): bool
                     break;
             }
         }
-        return array_key_exists($wantedPath, $config);
+        $hasConfig = array_key_exists($wantedPath, $config);
+        Mage::register("config_env_has_path_$wantedPath", $hasConfig);
+        return $hasConfig;
     }
 
     public function getAsArray(string $wantedScope): array
     {
+        $data = Mage::registry("config_env_array_$wantedScope");
+        if ($data !== null) {
+            return $data;
+        }
         $env = $this->getEnv();
         $config = [];
 
@@ -160,7 +175,7 @@ public function getAsArray(string $wantedScope): array
                     break;
             }
         }
-
+        Mage::register("config_env_array_$wantedScope", $config);
         return $config;
     }