Clear hasDataChanges flag after loading collection items (#3000)

* Clear hasDataChanges flag after loading collection items

* Prevent unnecessary save of order history collection items

Author: elidrissidev

app/code/core/Mage/Sales/Model/Order/Status/History.php

@@ -38,7 +38,6 @@
  * @method $this setParentId(int $value)
  * @method string getStatus()
  * @method $this setStatus(string $value)
- * @method $this setStoreId(int $value)
  * @method int getIsVisibleOnFront()
  * @method $this setIsVisibleOnFront(int $value)
  */
@@ -69,18 +68,27 @@ protected function _construct()
     }
 
     /**
-     * Set order object and grab some metadata from it
+     * Set order object
      *
      * @param   Mage_Sales_Model_Order $order
      * @return  $this
      */
     public function setOrder(Mage_Sales_Model_Order $order)
     {
         $this->_order = $order;
-        $this->setStoreId($order->getStoreId());
         return $this;
     }
 
+    /**
+     * Get store id
+     *
+     * @throws Mage_Core_Model_Store_Exception
+     */
+    public function getStoreId(): int
+    {
+        return $this->getStore()->getStoreId();
+    }
+
     /**
      * Notification flag
      *

lib/Varien/Data/Collection/Db.php

@@ -587,6 +587,7 @@ public function load($printQuery = false, $logQuery = false)
                     $item->setIdFieldName($this->getIdFieldName());
                 }
                 $item->addData($row);
+                $item->setDataChanges(false);
                 $this->addItem($item);
             }
         }