Reduced number of getId() calls in lib/Varien/Data/Tree/Node/Collection.php (#2957)

luigifab · web-flow · commit b1a6176cef53 · 2023-01-17T09:57:39.000Z
diff --git a/lib/Varien/Data/Tree/Node/Collection.php b/lib/Varien/Data/Tree/Node/Collection.php
@@ -129,8 +129,9 @@ public function add(Varien_Data_Tree_Node $node)
      */
     public function delete($node)
     {
-        if (isset($this->_nodes[$node->getId()])) {
-            unset($this->_nodes[$node->getId()]);
+        $id = $node->getId();
+        if (isset($this->_nodes[$id])) {
+            unset($this->_nodes[$id]);
         }
         return $this;
     }

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,9 @@ public function add(Varien_Data_Tree_Node $node)`
`129`	`129`	`*/`
`130`	`130`	`public function delete($node)`
`131`	`131`	`{`
`132`		`- if (isset($this->_nodes[$node->getId()])) {`
`133`		`- unset($this->_nodes[$node->getId()]);`
	`132`	`+ $id = $node->getId();`
	`133`	`+ if (isset($this->_nodes[$id])) {`
	`134`	`+ unset($this->_nodes[$id]);`
`134`	`135`	`}`
`135`	`136`	`return $this;`
`136`	`137`	`}`