Added ability to add target attribute for adminhtml menu items (#1985)

* Adminhtml menu cleanup, added ability to add target for menu items

* Added ability to add target for menu items

Author: Sekiphp

app/code/core/Mage/Adminhtml/Block/Page/Menu.php

@@ -95,7 +95,9 @@ public function getCacheKeyInfo()
      */
     public function getMenuArray()
     {
-        return $this->_buildMenuArray();
+        $parent = Mage::getSingleton('admin/config')->getAdminhtmlConfig()->getNode('menu');
+
+        return $this->_buildMenuArray($parent);
     }
 
     /**
@@ -127,12 +129,8 @@ protected function _getHelperValue(Varien_Simplexml_Element $child)
      * @param int $level
      * @return array
      */
-    protected function _buildMenuArray(Varien_Simplexml_Element $parent=null, $path='', $level=0)
+    protected function _buildMenuArray(Varien_Simplexml_Element $parent, $path='', $level=0)
     {
-        if (is_null($parent)) {
-            $parent = Mage::getSingleton('admin/config')->getAdminhtmlConfig()->getNode('menu');
-        }
-
         $parentArr = array();
         $sortOrder = 0;
         foreach ($parent->children() as $childName => $child) {
@@ -167,6 +165,10 @@ protected function _buildMenuArray(Varien_Simplexml_Element $parent=null, $path=
 
             $menuArr['level'] = $level;
 
+            if ($child->target) {
+                $menuArr['target'] = $child->target;
+            }
+
             if ($child->children) {
                 $menuArr['children'] = $this->_buildMenuArray($child->children, $path.$childName.'/', $level+1);
             }
@@ -294,6 +296,7 @@ public function getMenuLevel($menu, $level = 0)
                 . (!empty($level) && !empty($item['last']) ? ' last' : '')
                 . ' level' . $level . '"> <a href="' . $item['url'] . '" '
                 . (!empty($item['title']) ? 'title="' . $item['title'] . '"' : '') . ' '
+                . (!empty($item['target']) ? 'target="' . $item['target'] . '"' : '') . ' '
                 . (!empty($item['click']) ? 'onclick="' . $item['click'] . '"' : '') . ' class="'
                 . ($level === 0 && !empty($item['active']) ? 'active' : '') . '"><span>'
                 . $this->escapeHtml($item['label']) . '</span></a>' . PHP_EOL;

app/design/adminhtml/default/default/template/page/menu.phtml

@@ -23,6 +23,8 @@
  * @copyright   Copyright (c) 2006-2020 Magento, Inc. (http://www.magento.com)
  * @license     http://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
  */
+
+/** @var $this Mage_Adminhtml_Block_Page_Menu */
 ?>
 
 <div class="nav-bar">