Fixed "Credit Memo not created when refund issued by merchant" (#2729)

luigifab · web-flow · commit bdd0697fd2d9 · 2023-10-04T08:58:11.000+01:00
diff --git a/app/code/core/Mage/Sales/Model/Order/Payment.php b/app/code/core/Mage/Sales/Model/Order/Payment.php
@@ -805,7 +805,7 @@ public function registerRefundNotification($amount)
             $amount = $amountRefundLeft;
         }
 
-        if ($amount != $baseGrandTotal) {
+        if (Mage::helper('core')->getExactDivision($amount, $baseGrandTotal) != 0) {
             $transaction = new Varien_Object(['txn_id' => $this->getTransactionId()]);
             Mage::dispatchEvent('sales_html_txn_id', ['transaction' => $transaction, 'payment' => $this]);
             $transactionId = $transaction->getHtmlTxnId() ? $transaction->getHtmlTxnId() : $transaction->getTxnId();

Original file line number	Diff line number	Diff line change
`@@ -805,7 +805,7 @@ public function registerRefundNotification($amount)`
`805`	`805`	`$amount = $amountRefundLeft;`
`806`	`806`	`}`
`807`	`807`
`808`		`- if ($amount != $baseGrandTotal) {`
	`808`	`+ if (Mage::helper('core')->getExactDivision($amount, $baseGrandTotal) != 0) {`
`809`	`809`	`$transaction = new Varien_Object(['txn_id' => $this->getTransactionId()]);`
`810`	`810`	`Mage::dispatchEvent('sales_html_txn_id', ['transaction' => $transaction, 'payment' => $this]);`
`811`	`811`	`$transactionId = $transaction->getHtmlTxnId() ? $transaction->getHtmlTxnId() : $transaction->getTxnId();`