rector: ForRepeatedCountToOwnVariableRector (#4860)

- see https://getrector.com/rule-detail/for-repeated-count-to-own-variable-rector

Author: sreichel

.rector.php

@@ -51,7 +51,6 @@
             CodeQuality\Equal\UseIdenticalOverEqualWithSameTypeRector::class, # todo: TMP
             CodeQuality\Expression\InlineIfToExplicitIfRector::class, # todo: TMP (!?!)
             CodeQuality\Expression\TernaryFalseExpressionToIfRector::class, # todo: TMP (!?!)
-            CodeQuality\For_\ForRepeatedCountToOwnVariableRector::class, # todo: TMP
             CodeQuality\Foreach_\ForeachItemsAssignToEmptyArrayToAssignRector::class, # todo: TMP
             CodeQuality\FuncCall\SimplifyRegexPatternRector::class, # todo: TMP
             CodeQuality\FunctionLike\SimplifyUselessVariableRector::class, # todo: TMP

app/code/core/Mage/Catalog/Model/Layer/Filter/Price.php

@@ -373,7 +373,8 @@ public function apply(Zend_Controller_Request_Abstract $request, $filterBlock)
         $this->setInterval([$from, $to]);
 
         $priorFilters = [];
-        for ($i = 1; $i < count($filterParams); ++$i) {
+        $counter = count($filterParams);
+        for ($i = 1; $i < $counter; ++$i) {
             $priorFilter = $this->_validateFilter($filterParams[$i]);
             if ($priorFilter) {
                 $priorFilters[] = $priorFilter;

app/code/core/Mage/Core/functions.php

@@ -227,7 +227,8 @@ function mageDelTree($path)
 function mageParseCsv($string, $delimiter = ',', $enclosure = '"', $escape = '\\')
 {
     $elements = explode($delimiter, $string);
-    for ($i = 0; $i < count($elements); $i++) {
+    $counter = count($elements);
+    for ($i = 0; $i < $counter; $i++) {
         $nquotes = substr_count($elements[$i], $enclosure);
         if ($nquotes % 2 == 1) {
             for ($j = $i + 1; $j < count($elements); $j++) {

app/code/core/Mage/Paypal/Model/Report/Settlement.php

@@ -267,14 +267,19 @@ public function parseCsv($localCsv, $format = 'new')
                 case 'CH': // Section columns.
                     // In case ever the column order is changed, we will have the items recorded properly
                     // anyway. We have named, not numbered columns.
-                    for ($i = 1; $i < count($line); $i++) {
+                    $counter = count($line);
+                    // Section columns.
+                    // In case ever the column order is changed, we will have the items recorded properly
+                    // anyway. We have named, not numbered columns.
+                    for ($i = 1; $i < $counter; $i++) {
                         $sectionColumns[$line[$i]] = $i;
                     }
                     $flippedSectionColumns = array_flip($sectionColumns);
                     break;
                 case 'SB': // Section body.
                     $bodyItem = [];
-                    for ($i = 1; $i < count($line); $i++) {
+                    $counter = count($line);
+                    for ($i = 1; $i < $counter; $i++) {
                         $bodyItem[$rowMap[$flippedSectionColumns[$i]]] = $line[$i];
                     }
                     $this->_rows[] = $bodyItem;

lib/Mage/Archive.php

@@ -100,7 +100,8 @@ public function pack($source, $destination = 'packed.tgz', $skipRoot = false)
     {
         $archivers = $this->_getArchivers($destination);
         $interimSource = '';
-        for ($i = 0; $i < count($archivers); $i++) {
+        $counter = count($archivers);
+        for ($i = 0; $i < $counter; $i++) {
             if ($i == (count($archivers) - 1)) {
                 $packed = $destination;
             } else {

lib/Mage/System/Ftp.php

@@ -63,7 +63,8 @@ public function mkdirRecursive($path, $mode = 0777)
         $dir = explode('/', $path);
         $path = '';
         $ret = true;
-        for ($i = 0; $i < count($dir); $i++) {
+        $counter = count($dir);
+        for ($i = 0; $i < $counter; $i++) {
             $path .= '/' . $dir[$i];
             if (!@ftp_chdir($this->_conn, $path)) {
                 @ftp_chdir($this->_conn, '/');

lib/Magento/Profiler/OutputAbstract.php

@@ -115,7 +115,8 @@ private function _getSortedTimers()
 
         $prevTimerId = $timerIds[0];
         $result = [$prevTimerId];
-        for ($i = 1; $i < count($timerIds); $i++) {
+        $counter = count($timerIds);
+        for ($i = 1; $i < $counter; $i++) {
             $timerId = $timerIds[$i];
             /* Skip already added timer */
             if (!$timerId) {

lib/Varien/Filter/Template.php

@@ -269,7 +269,8 @@ protected function _getVariable($value, $default = '{no_value_defined}')
         $last = 0;
         /** @var Mage_Adminhtml_Model_Email_PathValidator $emailPathValidator */
         $emailPathValidator = $this->getEmailPathValidator();
-        for ($i = 0; $i < count($stackVars); $i++) {
+        $counter = count($stackVars);
+        for ($i = 0; $i < $counter; $i++) {
             if ($i == 0 && isset($this->_templateVars[$stackVars[$i]['name']])) {
                 // Getting of template value
                 $stackVars[$i]['variable'] = & $this->_templateVars[$stackVars[$i]['name']];

lib/Varien/Io/Abstract.php

@@ -72,8 +72,9 @@ public function getCleanPath($path)
 
         $pathParts = explode('/', $pathTokP);
         $realPathParts = [];
+        $counter = count($pathParts);
 
-        for ($i = 0, $realPathParts = []; $i < count($pathParts); $i++) {
+        for ($i = 0, $realPathParts = []; $i < $counter; $i++) {
             if ($pathParts[$i] == '.') {
                 continue;
             } elseif ($pathParts[$i] == '..') {