DHL International: PHP8: Cast $dimension before calling round() (#2438)

fballiano · web-flow · commit cc051f2f1807 · 2022-08-17T20:22:20.000+01:00
diff --git a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php
@@ -741,13 +741,13 @@ protected function _getDimension($dimension, $configWeightUnit = false)
 
         if ($configDimensionUnit != $countryDimensionUnit) {
             $dimension = (float) Mage::helper('usa')->convertMeasureDimension(
-                round($dimension, 3),
+                round((float)$dimension, 3),
                 $configDimensionUnit,
                 $countryDimensionUnit
             );
         }
 
-        return round($dimension, 3);
+        return round((float)$dimension, 3);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -741,13 +741,13 @@ protected function _getDimension($dimension, $configWeightUnit = false)`
`741`	`741`
`742`	`742`	`if ($configDimensionUnit != $countryDimensionUnit) {`
`743`	`743`	`$dimension = (float) Mage::helper('usa')->convertMeasureDimension(`
`744`		`- round($dimension, 3),`
	`744`	`+ round((float)$dimension, 3),`
`745`	`745`	`$configDimensionUnit,`
`746`	`746`	`$countryDimensionUnit`
`747`	`747`	`);`
`748`	`748`	`}`
`749`	`749`
`750`		`- return round($dimension, 3);`
	`750`	`+ return round((float)$dimension, 3);`
`751`	`751`	`}`
`752`	`752`
`753`	`753`	`/**`