Standardize PHPUnit assertion style: replace static::assert* with self::assert* (#4939)

* Initial plan

* Standardize PHPUnit assertion style: replace static::assert* with self::assert*

Co-authored-by: addison74 <[email protected]>

* Change PHPUnit static method call type to 'self'

* phpcs-fixer

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: addison74 <[email protected]>
Co-authored-by: Sven Reichel <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>

Author: 4 people

.php-cs-fixer.dist.php

@@ -15,7 +15,7 @@
         // PHP84: Adds or removes ? before single type declarations or |null at the end of union types when parameters have a default null value.
         'nullable_type_declaration_for_default_null_value' => true,
         // Calls to PHPUnit\Framework\TestCase static methods must all be of the same type, either $this->, self:: or static::
-        'php_unit_test_case_static_method_calls' => ['call_type' => 'static'],
+        'php_unit_test_case_static_method_calls' => ['call_type' => 'self'],
         // Convert double quotes to single quotes for simple strings.
         'single_quote' => true,
         // Arguments lists, array destructuring lists, arrays that are multi-line, match-lines and parameters lists must have a trailing comma.

tests/unit/Base/ClassLoadingTest.php

@@ -21,7 +21,7 @@ final class ClassLoadingTest extends TestCase
      */
     public function testClassExists(bool $expectedResult, string $class): void
     {
-        static::assertSame($expectedResult, class_exists($class));
+        self::assertSame($expectedResult, class_exists($class));
     }
 
     public function provideClassExistsData(): Generator

tests/unit/Base/DefaultConfigTest.php

@@ -24,7 +24,7 @@ final class DefaultConfigTest extends TestCase
      */
     public function testGetStoreConfig(string $expectedResult, string $path, bool|int|Mage_Core_Model_Store|null|string $store = null): void
     {
-        static::assertSame($expectedResult, Mage::getStoreConfig($path, $store));
+        self::assertSame($expectedResult, Mage::getStoreConfig($path, $store));
     }
 
 

tests/unit/Base/XmlFileLoadingTest.php

@@ -29,7 +29,7 @@ public function testFileLoading(string $filepath): void
             SimpleXMLElement::class,
             LIBXML_PEDANTIC, //not needed by OpenMage, but good to test more strictly
         );
-        static::assertNotEmpty($simplexml->asXML());
+        self::assertNotEmpty($simplexml->asXML());
     }
 
     /**
@@ -40,7 +40,7 @@ public function testXmlReaderIsValid(string $filepath): void
         /** @var XMLReader $xml */
         $xml = XMLReader::open($filepath);
         $xml->setParserProperty(XMLReader::VALIDATE, true);
-        static::assertTrue($xml->isValid());
+        self::assertTrue($xml->isValid());
     }
 
     public function provideXmlFiles(): Generator

tests/unit/Error/ProcessorTest.php

@@ -39,7 +39,7 @@ public function testGetHostUrl(string $expectedResult, array $serverVars): void
         foreach ($serverVars as $serverVar => $value) {
             $_SERVER[$serverVar] = $value;
         }
-        static::assertSame($expectedResult, $this->subject->getHostUrl());
+        self::assertSame($expectedResult, $this->subject->getHostUrl());
     }
 
     public function provideGetHostUrl(): Generator

tests/unit/Mage/Admin/Helper/BlockTest.php

@@ -31,7 +31,7 @@ public static function setUpBeforeClass(): void
      */
     public function testIsTypeAllowed(): void
     {
-        static::assertFalse(self::$subject->isTypeAllowed('some-type'));
+        self::assertFalse(self::$subject->isTypeAllowed('some-type'));
     }
 
     /**
@@ -40,6 +40,6 @@ public function testIsTypeAllowed(): void
      */
     public function testGetDisallowedBlockNames(): void
     {
-        static::assertSame(['install/end'], self::$subject->getDisallowedBlockNames());
+        self::assertSame(['install/end'], self::$subject->getDisallowedBlockNames());
     }
 }

tests/unit/Mage/Admin/Helper/DataTest.php

@@ -31,7 +31,7 @@ public static function setUpBeforeClass(): void
      */
     public function testGenerateResetPasswordLinkToken(): void
     {
-        static::assertIsString(self::$subject->generateResetPasswordLinkToken());
+        self::assertIsString(self::$subject->generateResetPasswordLinkToken());
     }
 
     /**
@@ -40,6 +40,6 @@ public function testGenerateResetPasswordLinkToken(): void
      */
     public function testGetResetPasswordLinkExpirationPeriod(): void
     {
-        static::assertIsInt(self::$subject->getResetPasswordLinkExpirationPeriod());
+        self::assertIsInt(self::$subject->getResetPasswordLinkExpirationPeriod());
     }
 }

tests/unit/Mage/Admin/Helper/VariableTest.php

@@ -31,6 +31,6 @@ public static function setUpBeforeClass(): void
      */
     public function testIsPathAllowed(): void
     {
-        static::assertIsBool(self::$subject->isPathAllowed(''));
+        self::assertIsBool(self::$subject->isPathAllowed(''));
     }
 }

tests/unit/Mage/Admin/Model/BlockTest.php

@@ -40,15 +40,15 @@ public function testValidate(bool|array $expectedResult, array $methods): void
     {
         $mock = $this->getMockWithCalledMethods(Subject::class, $methods);
 
-        static::assertInstanceOf(Subject::class, $mock);
-        static::assertEquals($expectedResult, $mock->validate());
+        self::assertInstanceOf(Subject::class, $mock);
+        self::assertEquals($expectedResult, $mock->validate());
     }
 
     /**
      * @group Model
      */
     public function testIsTypeAllowed(): void
     {
-        static::assertIsBool(self::$subject->isTypeAllowed('invalid-type'));
+        self::assertIsBool(self::$subject->isTypeAllowed('invalid-type'));
     }
 }

tests/unit/Mage/Admin/Model/ConfigTest.php

@@ -32,30 +32,30 @@ public static function setUpBeforeClass(): void
      */
     public function testGetAclAssert(): void
     {
-        static::assertFalse(self::$subject->getAclAssert(''));
+        self::assertFalse(self::$subject->getAclAssert(''));
     }
 
     /**
      * @group Model
      */
     public function testGetAclPrivilegeSet(): void
     {
-        static::assertFalse(self::$subject->getAclPrivilegeSet());
+        self::assertFalse(self::$subject->getAclPrivilegeSet());
     }
 
     /**
      * @group Model
      */
     public function testLoadAclResources(): void
     {
-        static::assertInstanceOf(Subject::class, self::$subject->loadAclResources(new Mage_Admin_Model_Acl()));
+        self::assertInstanceOf(Subject::class, self::$subject->loadAclResources(new Mage_Admin_Model_Acl()));
     }
 
     /**
      * @group Model
      */
     public function testGetAdminhtmlConfig(): void
     {
-        static::assertInstanceOf(Varien_Simplexml_Config::class, self::$subject->getAdminhtmlConfig());
+        self::assertInstanceOf(Varien_Simplexml_Config::class, self::$subject->getAdminhtmlConfig());
     }
 }