Skip to content

PHPUnit: added/updated tests #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
May 7, 2025
Merged

PHPUnit: added/updated tests #4758

merged 50 commits into from
May 7, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Apr 19, 2025 •
edited
Loading

Description (*)

Added ~100 tests and updated all existing ones.

  • added all tests from Replace Zend_Validation #4612 and improved them (there will be some errors now)
  • split tests into testsuites
  • removed duplicated code
  • some cleanup (use static methods, ...)

Related Pull Requests

Questions or comments

To test controllers i have added this to composer.json

    "autoload-dev": {
        "classmap": ["app/code/*/*/*/controllers"],

Should we use it for core too? Ping @justinbeaty.

@github-actions github-actions bot added environment Component: Core Relates to Mage_Core Component: Cms Relates to Mage_Cms labels Apr 19, 2025
addison74
addison74 previously approved these changes Apr 27, 2025
View reviewed changes
@sreichel sreichel added this to the 20.14.0 milestone May 5, 2025
addison74
addison74 previously approved these changes May 5, 2025
View reviewed changes
@github-actions github-actions bot removed Component: Core Relates to Mage_Core Component: Cms Relates to Mage_Cms Component: Reports Relates to Mage_Reports Component: Adminhtml Relates to Mage_Adminhtml Component: Index Relates to Mage_Index labels May 6, 2025
@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: Cms Relates to Mage_Cms Component: Reports Relates to Mage_Reports Component: Adminhtml Relates to Mage_Adminhtml Component: Index Relates to Mage_Index labels May 6, 2025
colinmollenhour
colinmollenhour approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed it.. 😅

That's a lot of coverage now, nice work!

@colinmollenhour colinmollenhour merged commit ab1d4f5 into OpenMage:main May 7, 2025
23 checks passed
@sreichel
Copy link
Contributor Author

sreichel commented May 7, 2025

Thanks.

Total coverage is still below 10%, but starting with around 40 test last year and now having 800 is not so bad.

I'll try to add more frequently.

@sreichel sreichel deleted the phpunit-pre-symfony branch May 7, 2025 20:48
@sreichel sreichel added the chore label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@addison74 addison74 addison74 left review comments

Assignees
No one assigned
Labels
chore Component: Adminhtml Relates to Mage_Adminhtml Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: Index Relates to Mage_Index Component: Reports Relates to Mage_Reports composer Relates to composer.json environment git php-cs-fixer phpunit rector
Projects
None yet
Milestone
20.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @colinmollenhour @addison74