Skip to content

Commit 16c1dcc

Browse files
vtjnashclaude
andcommitted
build: remove unused REFNAME macro from SANITY_CHECK
REFNAME was defined as a preprocessor macro (-DREFNAME=$(*F)f$(BU)) but appears to have never been consumed by any source code. The SANITY_CHECK feature uses common_reference.h which has its own independent mechanism via BLASFUNC_REF macros with hardcoded REF_BU=f. For context, REFNAME was imported with GotoBLAS2 in 2011 but became dead code when the unit test framework added common_reference.h with its own naming scheme. The CMake version also had a broken $(*F) reference that could never work, but this was also moot since the macro was unused. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 parent c7b0304 commit 16c1dcc

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Makefile.system

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ SANITY_CHECK = 1
558558
endif
559559

560560
ifdef SANITY_CHECK
561-
CCOMMON_OPT += -DSANITY_CHECK -DREFNAME=$(*F)f$(BU)
561+
CCOMMON_OPT += -DSANITY_CHECK
562562
endif
563563

564564
MAX_STACK_ALLOC ?= 2048

cmake/os.cmake

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ if (UTEST_CHECK)
9898
endif ()
9999

100100
if (SANITY_CHECK)
101-
# TODO: need some way to get $(*F) (target filename)
102-
set(CCOMMON_OPT "${CCOMMON_OPT} -DSANITY_CHECK -DREFNAME=$(*F)f${BU}")
101+
set(CCOMMON_OPT "${CCOMMON_OPT} -DSANITY_CHECK")
103102
endif ()
104103

0 commit comments

Comments
 (0)