Skip to content

Commit 2fc7124

Browse files
authored
Avoid creating spurious non-suffixed c/zgemm_kernels
Plain cgemm_kernel and zgemm_kernel are not used anywhere, only cgemm_kernel_b etc. Needlessly building them (without any define like NN, CN, etc.) just happened to work on most platforms, but not on arm64. See #1870
1 parent 6ba30e2 commit 2fc7124

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

kernel/CMakeLists.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,13 @@ function (build_core TARGET_CORE KDIR TSUFFIX KERNEL_DEFINITIONS)
125125
set(USE_TRMM true)
126126
endif ()
127127

128-
foreach (float_type ${FLOAT_TYPES})
128+
foreach (float_type SINGLE DOUBLE)
129129
string(SUBSTRING ${float_type} 0 1 float_char)
130130
GenerateNamedObjects("${KERNELDIR}/${${float_char}GEMMKERNEL}" "" "gemm_kernel" false "" "" false ${float_type})
131+
endforeach()
131132

133+
foreach (float_type ${FLOAT_TYPES})
134+
string(SUBSTRING ${float_type} 0 1 float_char)
132135
if (${float_char}GEMMINCOPY)
133136
GenerateNamedObjects("${KERNELDIR}/${${float_char}GEMMINCOPY}" "${float_type}" "${${float_char}GEMMINCOPYOBJ}" false "" "" true ${float_type})
134137
endif ()

0 commit comments

Comments
 (0)