Skip to content

Commit 5a720cf

Browse files
authored
Re-enable loop unrolling in trmv and remove the scary warning
fixes #1748 as that half of the fix for #1332 appears to have been an overreaction on my part.
1 parent a5a1118 commit 5a720cf

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

driver/level2/trmv_U.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,12 @@ int CNAME(BLASLONG m, FLOAT *a, BLASLONG lda, FLOAT *b, BLASLONG incb, FLOAT *bu
5454
COPY_K(m, b, incb, buffer, 1);
5555
}
5656

57-
/*FIXME the GEMV unrolling performed here was found to be broken, see issue 1332 */
58-
/* Multiplying DTB size by 100 is just a quick-and-dirty hack to disable it for now[B */
57+
for (is = 0; is < m; is += DTB_ENTRIES){
5958

60-
for (is = 0; is < m; is += DTB_ENTRIES * 100){
61-
62-
min_i = MIN(m - is, DTB_ENTRIES * 100);
59+
min_i = MIN(m - is, DTB_ENTRIES);
6360

6461
#ifndef TRANSA
65-
if (is > 0){
66-
fprintf(stderr,"WARNING unrolling of the trmv_U loop may give wrong results\n");
62+
if (is > 0){
6763
GEMV_N(is, min_i, 0, dp1,
6864
a + is * lda, lda,
6965
B + is, 1,

0 commit comments

Comments
 (0)