Skip to content

Commit 67f39ad

Browse files
authored
Merge pull request #2939 from thrasibule/Makefile_cleanup
reuse variables defined in Makefile.system
2 parents 6e13a7e + 1917a4e commit 67f39ad

File tree

2 files changed

+3
-19
lines changed

2 files changed

+3
-19
lines changed

Makefile.x86_64

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ ifndef DYNAMIC_ARCH
4747
ifndef NO_AVX512
4848
ifeq ($(C_COMPILER), GCC)
4949
# cooperlake support was added in 10.1
50-
GCCVERSIONGTEQ10 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 10)
51-
GCCMINORVERSIONGTEQ1 := $(shell expr `$(CC) -dumpversion | cut -f2 -d.` \>= 1)
5250
ifeq ($(GCCVERSIONGTEQ10)$(GCCMINORVERSIONGTEQ1), 11)
5351
CCOMMON_OPT += -march=cooperlake
5452
FCOMMON_OPT += -march=cooperlake
@@ -73,10 +71,7 @@ ifndef DYNAMIC_ARCH
7371
ifndef NO_AVX2
7472
ifeq ($(C_COMPILER), GCC)
7573
# AVX2 support was added in 4.7.0
76-
GCCVERSIONGTEQ4 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 4)
77-
GCCVERSIONGTEQ5 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 5)
78-
GCCMINORVERSIONGTEQ7 := $(shell expr `$(CC) -dumpversion | cut -f2 -d.` \>= 7)
79-
GCCVERSIONCHECK := $(GCCVERSIONGTEQ5)$(GCCVERSIONGTEQ4)$(GCCMINORVERSIONGTEQ7)
74+
GCCVERSIONCHECK := $(GCCVERSIONGT4)$(GCCVERSIONGTEQ4)$(GCCMINORVERSIONGTEQ7)
8075
ifeq ($(GCCVERSIONCHECK), $(filter $(GCCVERSIONCHECK), 011 110 111))
8176
CCOMMON_OPT += -mavx2
8277
endif

kernel/Makefile

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ ifdef HAVE_SSSE3
1212
CFLAGS += -mssse3
1313
endif
1414

15-
ifeq ($(C_COMPILER), GCC)
16-
GCCVERSIONGTEQ9 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 9)
17-
GCCVERSIONGTEQ10 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 10)
18-
endif
19-
2015
ifeq ($(ARCH), power)
2116
ifeq ($(C_COMPILER), CLANG)
2217
override CFLAGS += -fno-integrated-as
@@ -26,20 +21,14 @@ endif
2621
AVX2OPT =
2722
ifeq ($(C_COMPILER), GCC)
2823
# AVX2 support was added in 4.7.0
29-
GCCVERSIONGTEQ4 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 4)
30-
GCCVERSIONGTEQ5 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 5)
31-
GCCMINORVERSIONGTEQ7 := $(shell expr `$(CC) -dumpversion | cut -f2 -d.` \>= 7)
32-
GCCVERSIONCHECK := $(GCCVERSIONGTEQ5)$(GCCVERSIONGTEQ4)$(GCCMINORVERSIONGTEQ7)
24+
GCCVERSIONCHECK := $(GCCVERSIONGT4)$(GCCVERSIONGTEQ4)$(GCCMINORVERSIONGTEQ7)
3325
ifeq ($(GCCVERSIONCHECK), $(filter $(GCCVERSIONCHECK), 011 110 111))
3426
AVX2OPT = -mavx2
3527
endif
3628
endif
3729
ifeq ($(C_COMPILER), CLANG)
3830
# Any clang posing as gcc 4.2 should be new enough (3.4 or later)
39-
GCCVERSIONGTEQ4 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 4)
40-
GCCVERSIONGTEQ5 := $(shell expr `$(CC) -dumpversion | cut -f1 -d.` \>= 5)
41-
GCCMINORVERSIONGTEQ2 := $(shell expr `$(CC) -dumpversion | cut -f2 -d.` \>= 2)
42-
GCCVERSIONCHECK := $(GCCVERSIONGTEQ5)$(GCCVERSIONGTEQ4)$(GCCMINORVERSIONGTEQ7)
31+
GCCVERSIONCHECK := $(GCCVERSIONGT4)$(GCCVERSIONGTEQ4)$(GCCMINORVERSIONGTEQ2)
4332
ifeq ($(GCCVERSIONCHECK), $(filter $(GCCVERSIONCHECK), 011 110 111))
4433
AVX2OPT = -mavx2
4534
endif

0 commit comments

Comments
 (0)