Fix thinko in skylake beta handling

fenrus75 · fenrus75 · commit 795285c587d4 · 2018-12-24T18:49:50.000Z
casting ints is cheaper but it has a rounding, not memory casing effect, resulting in
invalid outcome
diff --git a/kernel/x86_64/dgemm_beta_skylakex.c b/kernel/x86_64/dgemm_beta_skylakex.c
@@ -50,7 +50,7 @@ int CNAME(BLASLONG m, BLASLONG n, BLASLONG dummy1, FLOAT beta,
   FLOAT ctemp5, ctemp6, ctemp7, ctemp8;
 
   /* fast path.. just zero the whole matrix */
-  if (m == ldc && (unsigned long)beta == (unsigned long)ZERO) {
+  if (m == ldc && beta == ZERO) {
 	memset(c, 0, m * n * sizeof(FLOAT));
 	return 0;
   }
diff --git a/kernel/x86_64/sgemm_beta_skylakex.c b/kernel/x86_64/sgemm_beta_skylakex.c
@@ -50,7 +50,7 @@ int CNAME(BLASLONG m, BLASLONG n, BLASLONG dummy1, FLOAT beta,
   FLOAT ctemp5, ctemp6, ctemp7, ctemp8;
 
   /* fast path.. just zero the whole matrix */
-  if (m == ldc && (unsigned long)beta == (unsigned long)ZERO) {
+  if (m == ldc && beta == ZERO) {
 	memset(c, 0, m * n * sizeof(FLOAT));
 	return 0;
   }

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ int CNAME(BLASLONG m, BLASLONG n, BLASLONG dummy1, FLOAT beta,`
`50`	`50`	`FLOAT ctemp5, ctemp6, ctemp7, ctemp8;`
`51`	`51`
`52`	`52`	`/* fast path.. just zero the whole matrix */`
`53`		`- if (m == ldc && (unsigned long)beta == (unsigned long)ZERO) {`
	`53`	`+ if (m == ldc && beta == ZERO) {`
`54`	`54`	`memset(c, 0, m * n * sizeof(FLOAT));`
`55`	`55`	`return 0;`
`56`	`56`	`}`