Skip to content

Commit d85b968

Browse files
authored
Merge pull request #2891 from martin-frbg/fix-2886
Fix several bugs and omissions from the BFLOAT16 rename
2 parents 0892943 + 9dca578 commit d85b968

File tree

4 files changed

+32
-15
lines changed

4 files changed

+32
-15
lines changed

.travis.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,23 @@ matrix:
104104
# for matrix annotation only
105105
- TARGET_BOX=PPC64LE_LINUX_P9
106106

107+
- os: linux
108+
arch: ppc64le
109+
dist: bionic
110+
compiler: gcc
111+
before_script:
112+
- sudo add-apt-repository 'ppa:ubuntu-toolchain-r/test' -y
113+
- sudo apt-get update
114+
- sudo apt-get install gcc-9 gfortran-9 -y
115+
script:
116+
- make QUIET_MAKE=1 BUILD_BFLOAT16=1 BINARY=64 USE_OPENMP=1 CC=gcc-9 FC=gfortran-9
117+
- make -C test $COMMON_FLAGS $BTYPE
118+
- make -C ctest $COMMON_FLAGS $BTYPE
119+
- make -C utest $COMMON_FLAGS $BTYPE
120+
env:
121+
# for matrix annotation only
122+
- TARGET_BOX=PPC64LE_LINUX_P9
123+
107124
- os: linux
108125
compiler: gcc
109126
addons:

Makefile.tail

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
SHBLASOBJS_P = $(SHBLASOBJS:.$(SUFFIX)=.$(PSUFFIX))
1+
SBBLASOBJS_P = $(SBBLASOBJS:.$(SUFFIX)=.$(PSUFFIX))
22
SBLASOBJS_P = $(SBLASOBJS:.$(SUFFIX)=.$(PSUFFIX))
33
DBLASOBJS_P = $(DBLASOBJS:.$(SUFFIX)=.$(PSUFFIX))
44
QBLASOBJS_P = $(QBLASOBJS:.$(SUFFIX)=.$(PSUFFIX))
55
CBLASOBJS_P = $(CBLASOBJS:.$(SUFFIX)=.$(PSUFFIX))
66
ZBLASOBJS_P = $(ZBLASOBJS:.$(SUFFIX)=.$(PSUFFIX))
77
XBLASOBJS_P = $(XBLASOBJS:.$(SUFFIX)=.$(PSUFFIX))
8-
SHEXTOBJS_P = $(SHEXTOBJS:.$(SUFFIX)=.$(PSUFFIX))
8+
SBEXTOBJS_P = $(SBEXTOBJS:.$(SUFFIX)=.$(PSUFFIX))
99

1010
COMMONOBJS_P = $(COMMONOBJS:.$(SUFFIX)=.$(PSUFFIX))
1111

1212
HPLOBJS_P = $(HPLOBJS:.$(SUFFIX)=.$(PSUFFIX))
1313

14-
BLASOBJS = $(SHEXTOBJS) $(SHBLASOBJS) $(SBLASOBJS) $(DBLASOBJS) $(CBLASOBJS) $(ZBLASOBJS) $(CBAUXOBJS)
15-
BLASOBJS_P = $(SHEXTOBJS_P) $(SHBLASOBJS_P) $(SBLASOBJS_P) $(DBLASOBJS_P) $(CBLASOBJS_P) $(ZBLASOBJS_P) $(CBAUXOBJS_P)
14+
BLASOBJS = $(SBEXTOBJS) $(SBBLASOBJS) $(SBLASOBJS) $(DBLASOBJS) $(CBLASOBJS) $(ZBLASOBJS) $(CBAUXOBJS)
15+
BLASOBJS_P = $(SBEXTOBJS_P) $(SBBLASOBJS_P) $(SBLASOBJS_P) $(DBLASOBJS_P) $(CBLASOBJS_P) $(ZBLASOBJS_P) $(CBAUXOBJS_P)
1616

1717
ifdef EXPRECISION
1818
BLASOBJS += $(QBLASOBJS) $(XBLASOBJS)
@@ -24,23 +24,23 @@ BLASOBJS += $(QBLASOBJS) $(XBLASOBJS)
2424
BLASOBJS_P += $(QBLASOBJS_P) $(XBLASOBJS_P)
2525
endif
2626

27-
$(SHBLASOBJS) $(SHBLASOBJS_P) : override CFLAGS += -DBFLOAT16 -UDOUBLE -UCOMPLEX
27+
$(SBBLASOBJS) $(SBBLASOBJS_P) : override CFLAGS += -DBFLOAT16 -UDOUBLE -UCOMPLEX
2828
$(SBLASOBJS) $(SBLASOBJS_P) : override CFLAGS += -UDOUBLE -UCOMPLEX
2929
$(DBLASOBJS) $(DBLASOBJS_P) : override CFLAGS += -DDOUBLE -UCOMPLEX
3030
$(QBLASOBJS) $(QBLASOBJS_P) : override CFLAGS += -DXDOUBLE -UCOMPLEX
3131
$(CBLASOBJS) $(CBLASOBJS_P) : override CFLAGS += -UDOUBLE -DCOMPLEX
3232
$(ZBLASOBJS) $(ZBLASOBJS_P) : override CFLAGS += -DDOUBLE -DCOMPLEX
3333
$(XBLASOBJS) $(XBLASOBJS_P) : override CFLAGS += -DXDOUBLE -DCOMPLEX
34-
$(SHEXTOBJS) $(SHEXTOBJS_P) : override CFLAGS += -DBFLOAT16 -UDOUBLE -UCOMPLEX
34+
$(SBEXTOBJS) $(SBEXTOBJS_P) : override CFLAGS += -DBFLOAT16 -UDOUBLE -UCOMPLEX
3535

36-
$(SHBLASOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
36+
$(SBBLASOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
3737
$(SBLASOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
3838
$(DBLASOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
3939
$(QBLASOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
4040
$(CBLASOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
4141
$(ZBLASOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
4242
$(XBLASOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
43-
$(SHEXTOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
43+
$(SBEXTOBJS_P) : override CFLAGS += -DPROFILE $(COMMON_PROF)
4444

4545
libs :: $(BLASOBJS) $(COMMONOBJS)
4646
$(AR) $(ARFLAGS) -ru $(TOPDIR)/$(LIBNAME) $^

common.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ typedef long BLASLONG;
257257
typedef unsigned long BLASULONG;
258258
#endif
259259

260-
#ifndef BFLOAT16
260+
#ifndef bfloat16
261261
#include <stdint.h>
262262
typedef uint16_t bfloat16;
263263
#define BFLOAT16CONVERSION 1

interface/Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -283,9 +283,9 @@ CSBLAS3OBJS = \
283283
cblas_sgeadd.$(SUFFIX)
284284

285285
ifeq ($(BUILD_BFLOAT16),1)
286-
CBHBLAS1OBJS = cblas_sbdot.$(SUFFIX)
287-
CBHBLAS3OBJS = cblas_sbgemm.$(SUFFIX)
288-
CBHEXTOBJS = cblas_sbstobf16.$(SUFFIX) cblas_sbdtobf16.$(SUFFIX) cblas_sbf16tos.$(SUFFIX) cblas_dbf16tod.$(SUFFIX)
286+
CSBBLAS1OBJS = cblas_sbdot.$(SUFFIX)
287+
CSBBLAS3OBJS = cblas_sbgemm.$(SUFFIX)
288+
CSBEXTOBJS = cblas_sbstobf16.$(SUFFIX) cblas_sbdtobf16.$(SUFFIX) cblas_sbf16tos.$(SUFFIX) cblas_dbf16tod.$(SUFFIX)
289289
endif
290290

291291
CDBLAS1OBJS = \
@@ -535,19 +535,19 @@ endif
535535
clean ::
536536
@rm -f functable.h
537537

538-
level1 : $(BEXTOBJS) $(SHBLAS1OBJS) $(SBLAS1OBJS) $(DBLAS1OBJS) $(QBLAS1OBJS) $(CBLAS1OBJS) $(ZBLAS1OBJS) $(XBLAS1OBJS)
538+
level1 : $(SBEXTOBJS) $(SBBLAS1OBJS) $(SBLAS1OBJS) $(DBLAS1OBJS) $(QBLAS1OBJS) $(CBLAS1OBJS) $(ZBLAS1OBJS) $(XBLAS1OBJS)
539539
$(AR) $(ARFLAGS) -ru $(TOPDIR)/$(LIBNAME) $^
540540

541541
level2 : $(SBLAS2OBJS) $(DBLAS2OBJS) $(QBLAS2OBJS) $(CBLAS2OBJS) $(ZBLAS2OBJS) $(XBLAS2OBJS)
542542
$(AR) $(ARFLAGS) -ru $(TOPDIR)/$(LIBNAME) $^
543543

544-
level3 : $(SHBLAS3OBJS) $(SBLAS3OBJS) $(DBLAS3OBJS) $(QBLAS3OBJS) $(CBLAS3OBJS) $(ZBLAS3OBJS) $(XBLAS3OBJS)
544+
level3 : $(SBBLAS3OBJS) $(SBLAS3OBJS) $(DBLAS3OBJS) $(QBLAS3OBJS) $(CBLAS3OBJS) $(ZBLAS3OBJS) $(XBLAS3OBJS)
545545
$(AR) $(ARFLAGS) -ru $(TOPDIR)/$(LIBNAME) $^
546546

547547
aux : $(CBAUXOBJS)
548548
$(AR) $(ARFLAGS) -ru $(TOPDIR)/$(LIBNAME) $^
549549

550-
$(CSHBLASOBJS) $(CSHBLASOBJS_P) $(CSBLASOBJS) $(CSBLASOBJS_P) $(CDBLASOBJS) $(CDBLASOBJS_P) $(CQBLASOBJS) $(CQBLASOBJS_P) \
550+
$(CSBBLASOBJS) $(CSBBLASOBJS_P) $(CSBLASOBJS) $(CSBLASOBJS_P) $(CDBLASOBJS) $(CDBLASOBJS_P) $(CQBLASOBJS) $(CQBLASOBJS_P) \
551551
$(CCBLASOBJS) $(CCBLASOBJS_P) $(CZBLASOBJS) $(CZBLASOBJS_P) $(CXBLASOBJS) $(CXBLASOBJS_P) $(CBAUXOBJS_P) : override CFLAGS += -DCBLAS
552552

553553
srot.$(SUFFIX) srot.$(PSUFFIX) : rot.c

0 commit comments

Comments
 (0)