Skip to content

Commit 1bb8dbb

Browse files
committed
refactor: improve error handling in DatasetHandler for provisioner startup
1 parent 411544c commit 1bb8dbb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

backend/syft_space/components/datasets/handlers.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ async def _ensure_provisioner_running(
114114
state=new_state_dict,
115115
)
116116
except Exception as e:
117-
logger.error(f"Failed to start provisioner for '{dtype}': {e}")
117+
# Error already logged by provisioner, just update state and raise
118118
await self.provisioner_state_repository.upsert_status(
119119
dtype=dtype,
120120
status=ProvisionerStatus.ERROR,
@@ -244,9 +244,9 @@ async def startup_all_provisioners(self) -> None:
244244
# Use state.state as config (contains connection fields from last run)
245245
config = state.state.copy() if state.state else {}
246246
await self._ensure_provisioner_running(state.dtype, config)
247-
except Exception as e:
248-
logger.error(f"Failed to start provisioner '{state.dtype}': {e}")
249-
# Continue with other provisioners
247+
except Exception: # nosec B110 - error already logged by provisioner
248+
# Continue starting other provisioners
249+
pass
250250

251251
async def shutdown_all_provisioners(self) -> None:
252252
"""Stop all running provisioners.

0 commit comments

Comments
 (0)