Fix text overflow in various places

- Add a new string_truncate function that automatically adds ellipses (...) when necessary
- Replace in-place check for the string width in three different places of the code (datapack preview, song/pattern folder)
- Truncate recent file names in the greeting window + menu (the latter is still not fixed, there's something wrong with the menu width calculation)
- Width of the 'Song info' window now adapts to the MIDI file name as well

Author: Bentroen

Minecraft Note Block Studio.yyp

@@ -989,7 +989,7 @@ if (draw_tab("File")) {
     for (b = 0; b < 11; b += 1) {
         if (recent_song[b] = "") break
         c = floor(date_second_span(recent_song_time[b], date_current_datetime()))
-        str += seconds_to_str(c) + "$" + clean(filename_name(recent_song[b])) + "|"
+        str += seconds_to_str(c) + "$" + string_truncate(clean(filename_name(recent_song[b])), 310) + "|"
     }
     show_menu_ext("file", 0, 19, icon(icons.NEW)+"Ctrl + N$New song|"+
                              icon(icons.OPEN)+"Ctrl+O$Open song...|Recent songs...|\\|" + str + condstr(recent_song[0] != "", "-|Clear recent songs") + condstr(recent_song[0] = "", "^!No recent songs") + "|/|-|"+

scripts/control_draw/control_draw.gml

@@ -21,4 +21,4 @@ if (string_lettersdigits(name) = "") {
 	}
 }
 
-return string_maxwidth(preview, 350) + condstr(string_width(preview) > 350, "...")
+return string_truncate(preview, 350)

scripts/dat_preview/dat_preview.gml

@@ -118,7 +118,7 @@ for (a = 0; a < 11; a += 1) {
         }
     }
     draw_sprite(spr_frame5, theme * 3 + m, b, c)
-    draw_text(b + 2 + (m = 2), c + 1 + (m = 2), filename_name(recent_song[a]))
+    draw_text(b + 2 + (m = 2), c + 1 + (m = 2), string_truncate(filename_name(recent_song[a]), 220))
     draw_set_halign(fa_right)
     draw_text(b + 316 + (m = 2), c + 1 + (m = 2), seconds_to_str(floor(date_second_span(recent_song_time[a], date_current_datetime()))))
     draw_set_halign(fa_left)

scripts/draw_window_greeting/draw_window_greeting.gml

@@ -100,7 +100,7 @@ if (selected_tab = 0) {
 		refreshrate=1
     }
 
-	draw_text(x1 + 22, y1 + 260, "Song folder: " + string_maxwidth(songfolder, 360) + condstr(string_width(songfolder) > 360, "..."))
+	draw_text(x1 + 22, y1 + 260, "Song folder: " + string_truncate(songfolder, 360))
     popup_set_window(x1 + 22, y1 + 260, 430, 18, songfolder)
     if (draw_button2(x1 + 22, y1 + 276, 76, "Open")) {
         if (!directory_exists_lib(songfolder)) {
@@ -116,7 +116,7 @@ if (selected_tab = 0) {
     }
     if (draw_button2(x1 + 22 + 84 + 84, y1 + 276, 96, "Use default")) songfolder = songs_directory
 
-	draw_text(x1 + 22, y1 + 310, "Pattern folder: " + string_maxwidth(patternfolder, 360) + condstr(string_width(patternfolder) > 360, "..."))
+	draw_text(x1 + 22, y1 + 310, "Pattern folder: " + string_truncate(patternfolder, 360))
     popup_set_window(x1 + 22, y1 + 300, 430, 18, patternfolder)
     if (draw_button2(x1 + 22, y1 + 326, 76, "Open")) {
         if (!directory_exists_lib(patternfolder)) {

scripts/draw_window_preferences/draw_window_preferences.gml

@@ -1,5 +1,5 @@
 // draw_window_songinfo()
-var x1, y1, a, b, n, str, w, h, yy, w1, w2, w3, w4, col, r, g, b, str2, cut;
+var x1, y1, a, b, n, str, w, h, yy, w1, w2, w3, w4, w5, w6, col, r, g, b, str2, cut;
 with (obj_popup) instance_destroy()
 global.popup = 0
 if (song_name = "" && window = w_songinfo) {window = 0 return 0}
@@ -12,16 +12,22 @@ if (str[0] = "") str[0] = "Untitled song"
 
 str[1] = song_author
 str[2] = song_orauthor
+str[3] = song_midi
 draw_set_font(fnt_info_big)
 w = max(string_width(str[0]) + 32, 400)
 draw_set_font(fnt_info_med_bold)
 w2 = string_width(str[1])
 w4 = string_width(str[2])
+draw_set_font(fnt_mainbold)
+w6 = string_width(str[3])
 draw_set_font(fnt_info_med)
 w1 = string_width("Created by ")
 w3 = string_width("Originally created by ")
-w = max(w1 + w2, w)
+draw_set_font(fnt_main)
+w5 = string_width("Imported from ")
+w = max(w1 + w2 + 32, w)
 w = max(w3 + w4 + 32, w)
+w = max(w5 + w6 + 32, w)
 draw_set_font(fnt_main)
 var songdescwrap, songdeschei;
 songdescwrap = string_word_wrap(song_desc, 216)

scripts/draw_window_songinfo/draw_window_songinfo.gml

@@ -0,0 +1,11 @@
+// string_truncate(str, maxwidth)
+// Truncates a string to maxwidth and adds ellipses (...) at the end
+
+var str, maxwidth
+str = argument0
+maxwidth = argument1
+
+if (string_width(str) > maxwidth) {
+	return string_maxwidth(str, maxwidth) + "..."
+}
+return str