Fix "Sucessfully updated" text not appearing after updating

Create a new variable `update_success` that bypasses the other status options when true. The "Successfully updated!" string would never actually appear, since the async update check would override it later with "You are using the latest version!" (`update == 2`).

This text only started appearing before due to a bug solved in 9440548, in which the update check would be stuck at "Checking for updates...". Since the logic for actually verifying if there's a newer version was never executed, the `update` status "had a chance" to stay set to 3, which would display the text properly.

Author: Bentroen

scripts/control_create/control_create.gml

@@ -87,6 +87,7 @@ function control_create() {
 	update = 0
 	check_update = 1
 	check_prerelease = 0
+	update_success = 0
 	show_welcome = 1
 	scroll_wheel = 0
 	theme = 3 // Using Fluent as the default theme
@@ -527,7 +528,7 @@ function control_create() {
 		if (theme = 2) fdark = 1
 		theme = 3 // Sets to the Fluent theme when updated
 	    window = w_update
-	    update = 3
+	    update_success = 1
 	}
 
 	// Delete old installer

scripts/draw_window_greeting/draw_window_greeting.gml

@@ -16,32 +16,33 @@ function draw_window_greeting() {
 		if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "Running from the GameMaker IDE.")
 		else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "在 IDE 中运行")	
 	} else if (check_update) {
-	    if (update = -1) {
-	        draw_set_color(c_red)
-			if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "Could not check for updates")
-	        else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "检查更新失败")
-	    }
-	    if (update = 0) {
-	        //draw_set_color(c_gray)
-			if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "Checking for updates...")
-	        else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "正在检查更新……")
-	    }
-	    if (update = 1) {
-	        draw_set_color(33023)
-			if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "There is an update available!")
-	        else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "有新版本！")
-	    }
-	    if (update = 2) {
-	        draw_set_color(c_green)
-			if (theme == 2) draw_set_color(c_lime)
-			if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "You are using the latest version!")
-	        else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "已为最新版本！")
-	    }
-	    if (update = 3) {
+		if (update_success) {
 	        draw_set_color(c_lime)
 			if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "Successfully updated!")
 	        else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "更新成功！")
-	    }
+	    } else {
+		    if (update = -1) {
+		        draw_set_color(c_red)
+				if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "Could not check for updates")
+		        else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "检查更新失败")
+		    }
+		    else if (update = 0) {
+		        //draw_set_color(c_gray)
+				if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "Checking for updates...")
+		        else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "正在检查更新……")
+		    }
+		    else if (update = 1) {
+		        draw_set_color(33023)
+				if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "There is an update available!")
+		        else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "有新版本！")
+		    }
+		    else if (update = 2) {
+		        draw_set_color(c_green)
+				if (theme == 2) draw_set_color(c_lime)
+				if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "You are using the latest version!")
+		        else draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "已为最新版本！")
+		    }
+		}
 	} else {
 	    draw_set_color(c_red)
 		if (language != 1) draw_text_center(x1 + 132, y1 + 248 + dev_label_offset, "Update checking disabled by user")