fix: handle user validation as nullable in song service methods

Author: tomast1337

server/src/song/song.controller.ts

@@ -80,7 +80,6 @@ export class SongController {
     @Param('id') id: string,
     @GetRequestToken() user: UserDocument | null,
   ): Promise<SongViewDto> {
-    user = validateUser(user);
     return await this.songService.getSong(id, user);
   }
 
@@ -130,7 +129,6 @@ export class SongController {
       'Access-Control-Expose-Headers': 'Content-Disposition',
     });
 
-    user = validateUser(user);
     const url = await this.songService.getSongDownloadUrl(id, user, src, false);
     res.redirect(HttpStatus.FOUND, url);
   }
@@ -142,8 +140,6 @@ export class SongController {
     @GetRequestToken() user: UserDocument | null,
     @Headers('src') src: string,
   ): Promise<string> {
-    user = validateUser(user);
-
     if (src != 'downloadButton') {
       throw new UnauthorizedException('Invalid source');
     }

server/src/song/song.service.ts

@@ -241,7 +241,7 @@ export class SongService {
 
   public async getSong(
     publicId: string,
-    user: UserDocument,
+    user: UserDocument | null,
   ): Promise<SongViewDto> {
     const foundSong = await this.songModel
       .findOne({ publicId: publicId })
@@ -272,7 +272,7 @@ export class SongService {
   // TODO: service should not handle HTTP -> https://www.reddit.com/r/node/comments/uoicw1/should_i_return_status_code_from_service_layer/
   public async getSongDownloadUrl(
     publicId: string,
-    user: UserDocument,
+    user: UserDocument | null,
     src?: string,
     packed: boolean = false,
   ): Promise<string> {