refactor: update AuthController to implement magic link login and redirect strategies

Author: tomast1337

server/src/auth/auth.controller.spec.ts

@@ -3,12 +3,18 @@ import { Request, Response } from 'express';
 
 import { AuthController } from './auth.controller';
 import { AuthService } from './auth.service';
+import { MagicLinkEmailStrategy } from './strategies/magicLinkEmail.strategy';
 
 const mockAuthService = {
   githubLogin: jest.fn(),
   googleLogin: jest.fn(),
   discordLogin: jest.fn(),
   verifyToken: jest.fn(),
+  loginWithEmail: jest.fn(),
+};
+
+const mockMagicLinkEmailStrategy = {
+  send: jest.fn(),
 };
 
 describe('AuthController', () => {
@@ -23,6 +29,10 @@ describe('AuthController', () => {
           provide: AuthService,
           useValue: mockAuthService,
         },
+        {
+          provide: MagicLinkEmailStrategy,
+          useValue: mockMagicLinkEmailStrategy,
+        },
       ],
     }).compile();
 
@@ -56,6 +66,13 @@ describe('AuthController', () => {
     });
   });
 
+  describe('githubLogin', () => {
+    it('should call AuthService.githubLogin', async () => {
+      await controller.githubLogin();
+      expect(authService.githubLogin).toHaveBeenCalled();
+    });
+  });
+
   describe('googleRedirect', () => {
     it('should call AuthService.googleLogin', async () => {
       const req = {} as Request;
@@ -78,6 +95,13 @@ describe('AuthController', () => {
     });
   });
 
+  describe('googleLogin', () => {
+    it('should call AuthService.googleLogin', async () => {
+      await controller.googleLogin();
+      expect(authService.googleLogin).toHaveBeenCalled();
+    });
+  });
+
   describe('discordRedirect', () => {
     it('should call AuthService.discordLogin', async () => {
       const req = {} as Request;
@@ -100,6 +124,46 @@ describe('AuthController', () => {
     });
   });
 
+  describe('discordLogin', () => {
+    it('should call AuthService.discordLogin', async () => {
+      await controller.discordLogin();
+      expect(authService.discordLogin).toHaveBeenCalled();
+    });
+  });
+
+  describe('magicLinkRedirect', () => {
+    it('should call AuthService.loginWithEmail', async () => {
+      const req = {} as Request;
+      const res = {} as Response;
+
+      await controller.magicLinkRedirect(req, res);
+
+      expect(authService.loginWithEmail).toHaveBeenCalledWith(req, res);
+    });
+
+    it('should handle exceptions', async () => {
+      const req = {} as Request;
+      const res = {} as Response;
+      const error = new Error('Test error');
+      (authService.loginWithEmail as jest.Mock).mockRejectedValueOnce(error);
+
+      await expect(controller.magicLinkRedirect(req, res)).rejects.toThrow(
+        'Test error',
+      );
+    });
+  });
+
+  describe('magicLinkLogin', () => {
+    it('should call AuthService.discordLogin', async () => {
+      const req = {} as Request;
+      const res = {} as Response;
+
+      await controller.magicLinkLogin(req, res);
+
+      expect(mockMagicLinkEmailStrategy.send).toHaveBeenCalledWith(req, res);
+    });
+  });
+
   describe('verify', () => {
     it('should call AuthService.verifyToken', async () => {
       const req = {} as Request;

server/src/auth/auth.controller.ts

@@ -1,5 +1,4 @@
 import {
-  Body,
   Controller,
   Get,
   Inject,
@@ -11,12 +10,10 @@ import {
 } from '@nestjs/common';
 import { AuthGuard } from '@nestjs/passport';
 import { ApiOperation, ApiResponse, ApiTags } from '@nestjs/swagger';
-import { NewEmailUserDto } from '@shared/validation/user/dto/NewEmailUser.dto';
 import type { Request, Response } from 'express';
 
 import { AuthService } from './auth.service';
 import { MagicLinkEmailStrategy } from './strategies/magicLinkEmail.strategy';
-import { Throttle } from '@nestjs/throttler';
 
 @Controller('auth')
 @ApiTags('auth')
@@ -51,7 +48,7 @@ export class AuthController {
       },
     },
   })
-  public async signInWithEmail(@Req() req: Request, @Res() res: Response) {
+  public async magicLinkLogin(@Req() req: Request, @Res() res: Response) {
     return this.magicLinkEmailStrategy.send(req, res);
   }
 
@@ -60,7 +57,7 @@ export class AuthController {
     summary: 'Will send the user a email with a single use login link',
   })
   @UseGuards(AuthGuard('magic-link'))
-  public async signIn(@Req() req: Request, @Res() res: Response) {
+  public async magicLinkRedirect(@Req() req: Request, @Res() res: Response) {
     return this.authService.loginWithEmail(req, res);
   }