fix: prevent SongWebhookService's onModuleInit from halting server startup (#25)

tomast1337 · tomast1337 · commit af56c9a23278 · 2024-12-31T09:49:38.000-03:00
- Fixed error handling in onModuleInit to avoid server initialization failure - Added unit tests for SongWebhookService's onModuleInit method Closes #25
diff --git a/server/src/song/song-webhook/song-webhook.service.ts b/server/src/song/song-webhook/song-webhook.service.ts
@@ -18,7 +18,7 @@ export class SongWebhookService implements OnModuleInit {
 
   async onModuleInit() {
     this.logger.log('Updating Discord webhooks for all songs');
-    await this.syncAllSongsWebhook();
+    this.syncAllSongsWebhook();
   }
 
   public async postSongWebhook(song: SongWithUser): Promise<string | null> {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ export class SongWebhookService implements OnModuleInit {`
`18`	`18`
`19`	`19`	`async onModuleInit() {`
`20`	`20`	`this.logger.log('Updating Discord webhooks for all songs');`
`21`		`- await this.syncAllSongsWebhook();`
	`21`	`+ this.syncAllSongsWebhook();`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`public async postSongWebhook(song: SongWithUser): Promise<string \| null> {`