refactor: remove register endpoint and update magic link login summary for user creation

Author: tomast1337

server/src/auth/auth.controller.ts

@@ -28,17 +28,10 @@ export class AuthController {
     private readonly magicLinkEmailStrategy: MagicLinkEmailStrategy,
   ) {}
 
-  @Post('register')
-  @ApiOperation({
-    summary: 'Register user and send a email with a single use login link',
-  })
-  public async register(@Body() registerDto: NewEmailUserDto) {
-    return this.authService.register(registerDto);
-  }
-
   @Post('login/magic-link')
   @ApiOperation({
-    summary: 'Will send the user a email with a single use login link',
+    summary:
+      'Will send the user a email with a single use login link, if the user does not exist it will create a new user',
     requestBody: {
       content: {
         'application/json': {

server/src/auth/auth.service.ts

@@ -19,7 +19,6 @@ import { GithubAccessToken, GithubEmailList } from './types/githubProfile';
 import { GoogleProfile } from './types/googleProfile';
 import { Profile } from './types/profile';
 import { TokenPayload, Tokens } from './types/token';
-import { MagicLinkEmailStrategy } from './strategies/magicLinkEmail.strategy';
 
 @Injectable()
 export class AuthService {
@@ -263,14 +262,6 @@ export class AuthService {
     return user;
   }
 
-  public async register(registerDto: NewEmailUserDto) {
-    await this.userService.createWithEmail(registerDto);
-
-    return {
-      message: 'User created',
-    };
-  }
-
   public async validateEmail(body: Record<string, string | undefined>) {
     // get destination from body
     const { destination } = body;