Skip to content

Commit 1aa33ff

Browse files
Update cutnrun ci (#124)
* fix: add files to cutnrun ci * lint: Snakefile * fix: AV CI labels * fix: controls with SEACR * fix: check for blanks in chip2input * bump: patch version * Fix: run peakcaller-frip for all samples and added expand to frip_seacr rule. --------- Co-authored-by: skchronicles <kuhnsa3@gmail.com>
1 parent c589857 commit 1aa33ff

File tree

5 files changed

+19
-10
lines changed

5 files changed

+19
-10
lines changed

.github/workflows/analytical-validation-tests.yaml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,9 @@ jobs:
184184
/opt2/.tests/WT_S4_R1.001.fastq.gz /opt2/.tests/WT_S4_R2.001.fastq.gz \
185185
--output /opt2/output --peakcall /opt2/.tests/peakcall_no_replicates_no_inputs.tsv \
186186
--contrasts /opt2/.tests/contrasts.tsv --mode local --dry-run
187+
- name: View the paired-end ATAC pipeline config file (without replicates, without inputs)
188+
run: |
189+
echo "Generated config file for ATAC pipeline (without replicates, without inputs)...." && jq -C '.' $PWD/output/config.json
187190
- name: Dry Run paired-end CUT & RUN pipeline, all options (without replicates, with inputs)
188191
run: |
189192
docker run -v $PWD:/opt2 snakemake/snakemake:v5.24.2 \
@@ -194,17 +197,22 @@ jobs:
194197
/opt2/.tests/Input_S4_R1.001.fastq.gz /opt2/.tests/Input_S4_R2.001.fastq.gz \
195198
--output /opt2/output --peakcall /opt2/.tests/peakcall_no_replicates_with_inputs.tsv \
196199
--contrasts /opt2/.tests/contrasts.tsv --mode local --dry-run
197-
- name: Dry Run paired-end CUT & RUN pipeline, all options (without replicates, without inputs)
200+
- name: View the paired-end CUT & RUN pipeline config file (without replicates, without inputs)
201+
run: |
202+
echo "Generated config file for CUT & RUN pipeline (without replicates, without inputs)...." && jq -C '.' $PWD/output/config.json
203+
- name: Dry Run paired-end CUT & RUN pipeline all options, all options (without replicates, without inputs)
198204
run: |
199205
docker run -v $PWD:/opt2 snakemake/snakemake:v5.24.2 \
200206
/opt2/chrom-seek run --assay cutnrun --genome hg38 --input \
201207
/opt2/.tests/WT_S1.R1.fastq.gz /opt2/.tests/WT_S1.R2.fastq.gz \
202208
/opt2/.tests/WT_S4_R1.001.fastq.gz /opt2/.tests/WT_S4_R2.001.fastq.gz \
209+
/opt2/.tests/Input_S1.R1.fastq.gz /opt2/.tests/Input_S1.R2.fastq.gz \
210+
/opt2/.tests/Input_S4_R1.001.fastq.gz /opt2/.tests/Input_S4_R2.001.fastq.gz \
203211
--output /opt2/output --peakcall /opt2/.tests/peakcall_no_replicates_no_inputs.tsv \
204212
--contrasts /opt2/.tests/contrasts.tsv --mode local --dry-run
205-
- name: View the paired-end ATAC pipeline config file (without replicates, without inputs)
213+
- name: View the paired-end CUT & RUN pipeline config file (without replicates, without inputs)
206214
run: |
207-
echo "Generated config file for ATAC pipeline (without replicates, without inputs)...." && jq -C '.' $PWD/output/config.json
215+
echo "Generated config file for CUT & RUN pipeline (without replicates, without inputs)...." && jq -C '.' $PWD/output/config.json
208216
- name: Lint Workflow
209217
continue-on-error: true
210218
run: |

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.2.3
1+
2.2.4

workflow/Snakefile

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,11 @@ rule_all_ins.extend(expand(
151151
rule_all_ins.append(join(workpath, "multiqc_report.html"))
152152
rule_all_ins.extend(expand(join(qc_dir, "{name}.preseq.dat"), name=samples))
153153
rule_all_ins.extend(
154-
expand(join(peakqc_dir, "FRiP", "{PeakTool}", "{PeakTool}.{name}.Q5DD.FRiP_table.txt"),
155-
PeakTool=PeakTools,
156-
name=chips)
154+
expand(
155+
join(peakqc_dir, "FRiP", "{PeakTool}", "{PeakTool}.{name}.Q5DD.FRiP_table.txt"),
156+
PeakTool=PeakTools,
157+
name=samples
158+
)
157159
)
158160
rule_all_ins.append(join(peakqc_dir, "FRiP", "summary.Q5DD.FRiP_heatmap.pdf"))
159161
rule_all_ins.extend(expand(

workflow/rules/paired/peakcall.smk

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,12 +201,11 @@ rule bam2bedgraph:
201201
bedtools genomecov -bg -i ${{tmp}}/sample.fragments.bed -g {params.reference} > {output}
202202
"""
203203

204-
205204
rule SEACR:
206205
input:
207206
exp = join(bg_dir, "{name}.bedgraph"),
208207
control = lambda w: join(bg_dir, f"{chip2input[w.name]}.bedgraph")
209-
if chip2input[w.name] and chip2input[w.name] != ""else [],
208+
if w.name in chip2input and chip2input[w.name] != "" else [],
210209
output:
211210
peaks = join(seacr_dir, "{name}", "{name}.stringent.bed")
212211
params:

workflow/rules/peakqc.smk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ rule FRiP_macsB:
126126

127127
rule FRiP_SEACR:
128128
input:
129-
peaks = join(seacr_dir, "{name}", "{name}.stringent.bed"),
129+
peaks = expand(join(seacr_dir, "{name}", "{name}.stringent.bed"), name=chips),
130130
bam = join(bam_dir, "{name}.Q5DD.bam"),
131131
output:
132132
tbl = join(peakqc_dir, "FRiP", "SEACR", "SEACR.{name}.Q5DD.FRiP_table.txt"),

0 commit comments

Comments
 (0)