Fix warnings about unused parameters

Move these implementations out of the headers. There is no
dominant benefit from inlining these functions.

Author: dg0yt

src/problemWidget.cpp

@@ -44,13 +44,22 @@ class QHBoxLayout;
 class QVBoxLayout;
 QT_END_NAMESPACE
 
+// ### Problem ###
+
 Problem::Problem()
 {
 	selection = 0;
 }
 
 Problem::~Problem() = default;
 
+void Problem::setToSolutionType(Problem::SolutionType /*type*/)
+{
+	// nothing
+}
+
+// ### ProblemWidget ###
+
 ProblemWidget::ProblemWidget(QWidget* parent) : QTableWidget(parent)
 {
 	verticalHeader()->setVisible(false);

src/problemWidget.h

@@ -60,7 +60,7 @@ class Problem
 	virtual QString getSolutionDescription(int i) = 0;
 	virtual void applySolution(int i) = 0;
 
-	virtual void setToSolutionType(SolutionType type) {}
+	virtual void setToSolutionType(SolutionType type);
 
 	inline const QString& getDescription() const {return description;}
 	inline int getSelection() const {return selection;}

src/scoringDialog.cpp

@@ -690,6 +690,11 @@ void ScoringCalculationPage::handicapDataChanged()
 	handicapList->sortItems();
 }
 
+void ScoringCalculationPage::handicapDataChanged(int /*index*/)
+{
+	handicapDataChanged();
+}
+
 void ScoringCalculationPage::customPointAddClicked()
 {
 	Ruleset* ruleset = getCurrentRuleset();

src/scoringDialog.h

@@ -168,7 +168,7 @@ public slots:
     void handicapCheckToggled(bool checked);
     void currentHandicapChanged(QListWidgetItem* current, QListWidgetItem* previous);
     void handicapDataChanged();
-	inline void handicapDataChanged(int index) {handicapDataChanged();}
+	void handicapDataChanged(int index);
 	void handicapAddClicked();
 	void handicapRemoveClicked();