[fix] clippy warnings and version conflict source.

Author: rusty1968

Cargo.lock

@@ -27,7 +27,6 @@ aes = { version = "0.8", default-features = false }
 ctr = { version = "0.9", default-features = false }
 aes-gcm = { version = "0.10", default-features = false, features = ["aes"] }
 cipher = { version = "0.4", default-features = false }
-generic-array = { version = "0.14", default-features = false }
 
 # Traits and utilities
 zerocopy = { workspace = true }

platform/impls/rustcrypto/Cargo.toml

@@ -7,9 +7,8 @@ use openprot_hal_blocking::cipher::{
 
 // RustCrypto imports for AES-CTR implementation
 use aes::Aes256;
-use cipher::{KeyIvInit, StreamCipher, StreamCipherSeek};
+use cipher::{generic_array::GenericArray, KeyIvInit, StreamCipher, StreamCipherSeek};
 use ctr::Ctr64BE;
-use generic_array::GenericArray;
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum RustCryptoCipherError {

platform/impls/rustcrypto/src/cipher.rs

@@ -162,7 +162,7 @@ impl DigestOp for DigestContext256 {
         // Convert SHA-256 output (32 bytes) to Digest<8> (8 x 32-bit words)
         let mut words = [0u32; 8];
         for (i, chunk) in result.chunks_exact(4).enumerate() {
-            words[i] = u32::from_le_bytes([chunk[0], chunk[1], chunk[2], chunk[3]]);
+            words[i] = u32::from_le_bytes(chunk.try_into().expect("chunk is exactly 4 bytes"));
         }
 
         let digest = Digest::new(words);
@@ -194,7 +194,7 @@ impl DigestOp for DigestContext384 {
         // Convert SHA-384 output (48 bytes) to Digest<12> (12 x 32-bit words)
         let mut words = [0u32; 12];
         for (i, chunk) in result.chunks_exact(4).enumerate() {
-            words[i] = u32::from_le_bytes([chunk[0], chunk[1], chunk[2], chunk[3]]);
+            words[i] = u32::from_le_bytes(chunk.try_into().expect("chunk is exactly 4 bytes"));
         }
 
         let digest = Digest::new(words);
@@ -226,7 +226,7 @@ impl DigestOp for DigestContext512 {
         // Convert SHA-512 output (64 bytes) to Digest<16> (16 x 32-bit words)
         let mut words = [0u32; 16];
         for (i, chunk) in result.chunks_exact(4).enumerate() {
-            words[i] = u32::from_le_bytes([chunk[0], chunk[1], chunk[2], chunk[3]]);
+            words[i] = u32::from_le_bytes(chunk.try_into().expect("chunk is exactly 4 bytes"));
         }
 
         let digest = Digest::new(words);