fix: improve path handling and fix event listener leak

Ref: #228 (comment)

- Replace `process.cwd()` with `__dirname` for reliable path resolution
- Fix HTTP server connection listener leak on multiple start/stop cycles
- Add default empty string for ref parameter in internalLinkBuilder
- Replace `parseInt()` with `Number()` for better type conversion
- Add `implementation_status` enum to `indexData` schema

Author: UlisesGascon

scripts/export-checklists.js

@@ -41,7 +41,7 @@ const { join } = require('path');
     const result = await knex.raw(query)
 
     // Write the result to a JSON file
-    const outputPath = join(process.cwd(), 'output', 'checklists.json')
+    const outputPath = join(__dirname, '../output', 'checklists.json')
     writeFileSync(outputPath, JSON.stringify(result.rows, null, 2))
 
     console.log(`Data exported to ${outputPath}`)

scripts/export-checks.js

@@ -34,7 +34,7 @@ const { join } = require('path')
     return { ...check, resources }
   })
 
-  writeFileSync(join(process.cwd(), 'output', 'checks.json'), JSON.stringify(formattedChecks, null, 2))
+  writeFileSync(join(__dirname, '../output', 'checks.json'), JSON.stringify(formattedChecks, null, 2))
   console.log('Checks exported to checks.json')
   await knex.destroy()
 })()

src/httpServer/index.js

@@ -47,6 +47,12 @@ const server = http.createServer(app)
 // Track all active connections
 const connections = new Set()
 
+// Set up connection tracking once (prevents listener leaks on multiple start/stop cycles)
+server.on('connection', connection => {
+  connections.add(connection)
+  connection.on('close', () => connections.delete(connection))
+})
+
 module.exports = () => ({
   start: async () => {
     const isDbConnected = await checkDatabaseConnection(knex)
@@ -64,13 +70,6 @@ module.exports = () => ({
       })
     })
 
-    // Track connections
-    server.on('connection', connection => {
-      connections.add(connection)
-      connection.on('close', () => {
-        connections.delete(connection)
-      })
-    })
     return server
   },
   stop: async () => {

src/httpServer/routers/website.js

@@ -21,7 +21,7 @@ function createWebRouter (knex, express) {
   })
 
   router.get('/projects/:id', async (req, res) => {
-    const projectId = parseInt(req.params.id)
+    const projectId = Number(req.params.id)
     if (isNaN(projectId)) {
       logger.error(`Invalid project ID: ${req.params.id}`)
       return res.status(404).render(notFoundTemplate)

src/reports/index.js

@@ -5,10 +5,11 @@ const { join } = require('path')
 const { initializeStore } = require('../store')
 const { validateProjectData, validateIndexData } = require('../schemas')
 
-const indexTemplatePath = join(process.cwd(), 'src', 'reports', 'templates', 'index.ejs')
-const projectTemplatePath = join(process.cwd(), 'src', 'reports', 'templates', 'project.ejs')
-const assetsFolder = join(process.cwd(), 'src', 'reports', 'assets')
-const destinationFolder = join(process.cwd(), 'output')
+const baseTemplatesPath = join(__dirname, 'templates')
+const indexTemplatePath = join(baseTemplatesPath, 'index.ejs')
+const projectTemplatePath = join(baseTemplatesPath, 'project.ejs')
+const assetsFolder = join(__dirname, 'assets')
+const destinationFolder = join(__dirname, '../../output')
 const copyFolder = async (from, to) => {
   try {
     // Ensure the target directory exists
@@ -108,7 +109,7 @@ const collectProjectData = async (knex, projectId) => {
   }
 }
 
-const internalLinkBuilder = (mode = 'static') => (ref, project) => {
+const internalLinkBuilder = (mode = 'static') => (ref = '', project) => {
   let finalRef = ref
   // remove leading slash
   if (mode === 'static') {
@@ -197,7 +198,7 @@ const generateStaticReports = async (knex, options = { clearPreviousReports: fal
     // Populate the project HTML template
     const projectHtml = ejs.render(projectTemplate, projectsData[project.name], {
       filename: projectTemplatePath,
-      views: [join(process.cwd(), 'src', 'reports', 'templates')]
+      views: [join(__dirname, 'templates')]
     })
     // @TODO: Prevent overwriting (edge case) at creation level
     if (project.name !== 'index') {
@@ -208,8 +209,8 @@ const generateStaticReports = async (knex, options = { clearPreviousReports: fal
   }
 
   await Promise.all([
-    writeFile('output/index_data.json', JSON.stringify(indexData, null, 2)),
-    writeFile('output/projects_data.json', JSON.stringify(projectsData, null, 2))
+    writeFile(join(destinationFolder, 'index_data.json'), JSON.stringify(indexData, null, 2)),
+    writeFile(join(destinationFolder, 'projects_data.json'), JSON.stringify(projectsData, null, 2))
   ])
 
   // copy assets folder
@@ -218,11 +219,11 @@ const generateStaticReports = async (knex, options = { clearPreviousReports: fal
   // Populate the index HTML template
   const indexHtml = ejs.render(indexTemplate, indexData, {
     filename: indexTemplatePath,
-    views: [join(process.cwd(), 'src', 'reports', 'templates')]
+    views: [join(__dirname, 'templates')]
   })
 
   // Save the index HTML file
-  await writeFile('output/index.html', indexHtml)
+  await writeFile(join(destinationFolder, 'index.html'), indexHtml)
   logger.info('Reports generated successfully')
 }
 

src/schemas/indexData.json

@@ -43,6 +43,10 @@
           "id": { "type": "integer" },
           "checklist_id": { "type": "integer" },
           "description": { "type": "string" },
+          "implementation_status": {
+            "type": "string",
+            "enum": ["pending", "in_progress", "completed"]
+          },
           "created_at": { "type": ["string", "object"], "format": "date-time" },
           "updated_at": { "type": ["string", "object"], "format": "date-time" }
         }

src/utils/index.js

@@ -55,7 +55,7 @@ const ensureGithubToken = () => {
 
 const getSeverityFromPriorityGroup = (priorityGroup) => {
   const priorityType = priorityGroup[0]
-  const priorityValue = parseInt(priorityGroup.slice(1), 10)
+  const priorityValue = Number(priorityGroup.slice(1), 10)
   // Recommendations (Rxx)
   if (priorityType === 'R') {
     return 'info'
@@ -107,13 +107,13 @@ const isDateWithinPolicy = (targetDate, policy) => {
 
   // Handle expiration policy
   if (policy.endsWith('d')) {
-    const days = parseInt(policy.replace('d', ''), 10)
+    const days = Number(policy.replace('d', ''), 10)
     expirationDate = add(targetDateObj, { days })
   } else if (policy.endsWith('m')) {
-    const months = parseInt(policy.replace('m', ''), 10)
+    const months = Number(policy.replace('m', ''), 10)
     expirationDate = add(targetDateObj, { months })
   } else if (policy.endsWith('q')) {
-    const quarters = parseInt(policy.replace('q', ''), 10)
+    const quarters = Number(policy.replace('q', ''), 10)
     expirationDate = add(targetDateObj, { months: quarters * 3 })
   } else {
     throw new Error('Unsupported policy format')