Skip to content

Commit 8a2bb2f

Browse files
committed
remove option of dither mode
1 parent 31d314b commit 8a2bb2f

File tree

6 files changed

+7
-26
lines changed

6 files changed

+7
-26
lines changed

rct-graphics-helper/magick_command.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,9 @@ def write_to_cache(self, id, delete_previous=False, next_file=""):
2828
" " + delete_addition + ")" + post
2929

3030
# Quantizes the image using a palette
31-
def quantize(self, palette, mode, amount):
32-
self.full_command += " -dither "+mode+(amount and " -define dither:diffusion-amount=" + str(amount) + "% -remap " or " ") + \
31+
def quantize(self, palette, amount):
32+
self.full_command += " -dither FloydSteinberg "+(amount and " -define dither:diffusion-amount=" + str(amount) + "% -remap " or " ") + \
3333
self.__stringify_input(palette) + " -colorspace sRGB"
34-
print(self.full_command)
3534

3635
# Trims the image to the smallest possible size and outputs the offset difference
3736
def trim(self):

rct-graphics-helper/operators/render_operator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def finish():
7979
context, self.palette_manager)
8080

8181

82-
render_task_processor.renderer.set_dither(general_props.dithering_mode, general_props.dithering_mode in general_props.dithering_modes_with_strength and general_props.dithering_strength)
82+
render_task_processor.renderer.set_dither(general_props.dithering_strength)
8383

8484
task = self.create_task(context)
8585

rct-graphics-helper/processors/sub_processes/frame_processors/post_processor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def process(self, frame, callback=None):
4141
magick_command.write_to_cache("render")
4242

4343
magick_command.quantize(self.renderer.get_palette_path(
44-
frame.base_palette),self.renderer.dither_mode, self.renderer.floyd_steinberg_diffusion)
44+
frame.base_palette), self.renderer.floyd_steinberg_diffusion)
4545

4646
# Force the recolorables to a palette that only contains the recolorable color
4747
channels_to_exclude_for_mai = ["Green", "Blue"]
@@ -57,7 +57,7 @@ def process(self, frame, callback=None):
5757

5858
forced_color_render = MagickCommand("mpr:render")
5959
forced_color_render.quantize(self.renderer.get_palette_path(
60-
palette), self.renderer.dither_mode, self.renderer.floyd_steinberg_diffusion)
60+
palette), self.renderer.floyd_steinberg_diffusion)
6161

6262
if i == 0:
6363
# Replace our clover green recolor 1 with the OpenRCT2 orange recolor 1

rct-graphics-helper/properties/general_properties.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,16 +94,6 @@ class GeneralProperties(bpy.types.PropertyGroup):
9494
description="Which color groups to dither to. Recolorables will be excluded from this palette when used to avoid conflicts.",
9595
size=len(defaults))
9696

97-
dithering_mode = bpy.props.EnumProperty(
98-
name = "Dithering Mode",
99-
items = (
100-
("FloydSteinberg", "Floyd-Steinberg", "Applies Floyd-Steinberg dithering, a configurable dithering algorithm which produces 'grid' dithering.", 1),
101-
# ("Riemersma", "Riemersma", "Applies Riemrsma dithering, a dithering algorithm which produces more 'random' dithering.", 2)
102-
)
103-
)
104-
105-
dithering_modes_with_strength = ["FloydSteinberg"]
106-
10797
dithering_strength = bpy.props.IntProperty(
10898
name = "Dithering Strength",
10999
description = "Floyd-Steinberg dithering strength",

rct-graphics-helper/rct_graphics_helper_panel.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,7 @@ def draw(self, context):
8383
row.separator()
8484

8585
row = layout.row()
86-
87-
box = layout.row()
88-
row = box.row()
89-
row.prop(properties,"dithering_mode")
90-
if properties.dithering_mode in properties.dithering_modes_with_strength:
91-
row = box.row()
92-
row.prop(properties,"dithering_strength")
86+
row.prop(properties,"dithering_strength")
9387

9488
row = layout.row()
9589
row.label("Dither Palette:")

rct-graphics-helper/renderer.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ def __init__(self, context, palette_manager):
3838
self.context = context
3939

4040
self.magick_path = "magick"
41-
self.dither_mode = "FloydSteinberg"
4241
self.floyd_steinberg_diffusion = 35
4342

4443
self.palette_manager = palette_manager
@@ -64,8 +63,7 @@ def __init__(self, context, palette_manager):
6463
bpy.app.handlers.render_complete.append(self._render_finished)
6564
bpy.app.handlers.render_cancel.append(self._render_reset)
6665

67-
def set_dither(self, mode, percent):
68-
self.dither_mode = mode
66+
def set_dither(self, percent):
6967
self.floyd_steinberg_diffusion = percent
7068

7169
# Render out the current scene

0 commit comments

Comments
 (0)