-
Notifications
You must be signed in to change notification settings - Fork 22
Overuse of "atSource" boolean var (and more) #827
Copy link
Copy link
Labels
area:servicesServices, helpers, utils and i18n ("logical" stuff)Services, helpers, utils and i18n ("logical" stuff)area:viewActual components ("visual" stuff)Actual components ("visual" stuff)code-qualityTechnical enhancementsTechnical enhancements
Description
At some places in the code, we use atSource (boolean) to deal with source/target expected behaviors. However, this can lead to misunderstanding when the return type of a method should return a boolean as well.
private filterTimeTrainrunsectionNonStop(
viewObject: TrainrunSectionViewObject,
atSource: boolean,
isArrival: boolean,
): boolean {I don't know what should be done
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area:servicesServices, helpers, utils and i18n ("logical" stuff)Services, helpers, utils and i18n ("logical" stuff)area:viewActual components ("visual" stuff)Actual components ("visual" stuff)code-qualityTechnical enhancementsTechnical enhancements