-
Notifications
You must be signed in to change notification settings - Fork 22
TrainrunSectionValidator does not take into account the current TimeDisplayPrecision value #846
Copy link
Copy link
Labels
area:servicesServices, helpers, utils and i18n ("logical" stuff)Services, helpers, utils and i18n ("logical" stuff)bug:minorThe feature is not compromised (e.g. slight css bug)The feature is not compromised (e.g. slight css bug)
Milestone
Description
What is the input mode?
Mouse
What type of issue is it?
Functionality
What happened?
Following of #831 (work done here #845)
The issue is not yet fully fixed.
The issue here is that TrainrunSectionValidator methods are static are then cannot use the state of FilterService.getTimeDisplayPrecision().
This results as the time precision is not updated (and the validations that depends on it):
Enregistrement.de.l.ecran.2026-02-20.142222.mp4
What could be done is to refactor TrainrunSectionValidator to make non-static, and inject FilterService in it.
What did you expect to happen?
If I write "2" in the decimal displayed input, then if I set 0.01 of travel time, I should get no warning (yellow)
How can we reproduce it (as minimally and precisely as possible)?
video
On which environments the bug occurs?
Local
On which browser the bug occurs?
Firefox
Netzgrafik-Editor version (top left corner Version x.yy.zz)
2.10.14
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area:servicesServices, helpers, utils and i18n ("logical" stuff)Services, helpers, utils and i18n ("logical" stuff)bug:minorThe feature is not compromised (e.g. slight css bug)The feature is not compromised (e.g. slight css bug)