-
Notifications
You must be signed in to change notification settings - Fork 22
De-duplicate checkMissingTransitions methods #885
Copy link
Copy link
Open
Labels
area:servicesServices, helpers, utils and i18n ("logical" stuff)Services, helpers, utils and i18n ("logical" stuff)code-qualityTechnical enhancementsTechnical enhancements
Description
NodeService.checkAndFixMissingTransitions() and TrainrunSectionService.checkMissingTransitionsAfterDeletion() methods are very close, but don't do the same thing. This code duplication made a bug very difficult to detect in this PR: b42f4e9
I suggest to de-duplicate this code and spread the use of a single method.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area:servicesServices, helpers, utils and i18n ("logical" stuff)Services, helpers, utils and i18n ("logical" stuff)code-qualityTechnical enhancementsTechnical enhancements