Conversation
Contributor
Author
|
I just add some comments. At the moment for me the fix is not yet clear. What we like to fix and how in detail! |
aiAdrian
force-pushed
the
846-trainrunsectionvalidator-does-not-take-into-account-the-current-timedisplayprecision-value
branch
from
eaf4a43 to
3c731a5
Compare
aiAdrian
changed the title
Member
|
In OSRD our minimum travel time is 1 microsecond (PostgreSQL time resolution). I would be careful about forbidding small values since these can happen pretty easily when adding intermediate stops. Maybe we can allow such values but still show a warning? |
Contributor
Author
Thanks for this information. In Netzgrafik the time are in Minutes 🫠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 0.01 min equals 0.6 s, we enforce that such values are not allowed internally. I double checked this assumption with Martin (BO) Netzgrafik at SBB.
The validator warning should only be triggered when e.g. a third‑party JSON file is imported. For strategic planning, the minimum allowed value is 0.1.
OSRD? What do you have a minimal travelTime for edges (second) .... ?
@louisgreiner