Skip to content

Commit 135faa7

Browse files
committed
front: remove unnecessary removal of vite overlay
Since we already listen to console errors using page.on to fail the test, removing the vite overlay is no longer needed. If the overlay is visible in the UI, it indicates a real issue. Signed-off-by: Maymanaf <med.aymen.naf@gmail.com>
1 parent 405514a commit 135faa7

15 files changed

+1
-29
lines changed

front/tests/009-op-simulation-settings-tab.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ test.describe('Simulation Settings Tab Verification', () => {
122122
await page.goto(
123123
`/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenario.id}`
124124
);
125-
await operationalStudiesPage.removeViteOverlay();
126125
await waitForInfraStateToBeCached(infra.id);
127126
});
128127
await test.step('Add a new train schedule, set its properties and perform pathfinding', async () => {

front/tests/010-stdcm.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ test.describe('Verify stdcm simulation page', () => {
6161
];
6262

6363
await page.goto('/stdcm');
64-
await stdcmPage.removeViteOverlay();
6564
await waitForInfraStateToBeCached(infra.id);
6665
});
6766

front/tests/011-stdcm-simulation-sheet.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ test.describe('Verify stdcm simulation page', () => {
6363
];
6464

6565
await page.goto('/stdcm');
66-
await stdcmPage.removeViteOverlay();
6766
await waitForInfraStateToBeCached(infra.id);
6867
});
6968

front/tests/012-stdcm-feedback-mail.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ test.describe('Stdcm feedback card', () => {
4848
new SimulationResultPage(page),
4949
];
5050
await page.goto('/stdcm');
51-
await stdcmPage.removeViteOverlay();
5251
await waitForInfraStateToBeCached(infra.id);
5352
});
5453

front/tests/013-stdcm-linked-train.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ test.describe('Verify stdcm simulation page', () => {
6666
];
6767

6868
await page.goto('/stdcm');
69-
await stdcmPage.removeViteOverlay();
7069
await waitForInfraStateToBeCached(infra.id);
7170
});
7271

front/tests/014-stdcm-missing-fields.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ test.describe('Verify stdcm missing fields', () => {
4242
];
4343

4444
await page.goto('/stdcm');
45-
await stdcmPage.removeViteOverlay();
46-
4745
await waitForInfraStateToBeCached(infra.id);
4846
});
4947

front/tests/015-train-timetable.spec.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import {
3131
VALID_PACED_TRAINS,
3232
VALID_TRAIN_SCHEDULE,
3333
} from './assets/constants/timetable-items-count';
34-
import OperationalStudiesPage from './pages/operational-studies/operational-studies-page';
3534
import PacedTrainSection from './pages/operational-studies/paced-train-section';
3635
import ScenarioTimetableSection from './pages/operational-studies/scenario-timetable-section';
3736
import { waitForInfraStateToBeCached } from './utils';
@@ -52,7 +51,6 @@ const frTranslations = {
5251
test.describe('Verify train schedule elements and filters', () => {
5352
let scenarioTimetableSection: ScenarioTimetableSection;
5453
let pacedTrainSection: PacedTrainSection;
55-
let operationalStudiesPage: OperationalStudiesPage;
5654

5755
let project: Project;
5856
let study: Study;
@@ -69,16 +67,14 @@ test.describe('Verify train schedule elements and filters', () => {
6967
test.beforeEach(
7068
'Navigate to scenario page and wait for infrastructure to be loaded',
7169
async ({ page }) => {
72-
[operationalStudiesPage, scenarioTimetableSection, pacedTrainSection] = [
73-
new OperationalStudiesPage(page),
70+
[scenarioTimetableSection, pacedTrainSection] = [
7471
new ScenarioTimetableSection(page),
7572
new PacedTrainSection(page),
7673
];
7774

7875
await page.goto(
7976
`/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenario.id}`
8077
);
81-
await operationalStudiesPage.removeViteOverlay();
8278
await waitForInfraStateToBeCached(infra.id);
8379
}
8480
);

front/tests/017-paced-train-management.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ test.describe('Verify simulation configuration in operational studies for train
120120
await page.goto(
121121
`/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenario.id}`
122122
);
123-
await operationalStudiesPage.removeViteOverlay();
124123
await waitForInfraStateToBeCached(infra.id);
125124
}
126125
);

front/tests/021-get-manchette.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ test.describe('Verify manchette and space time diagram', () => {
102102
await page.goto(
103103
`/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenarioItems.id}`
104104
);
105-
await simulationResultPage.removeViteOverlay();
106105
await waitForInfraStateToBeCached(infra.id);
107106
});
108107

front/tests/022-round-trips.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ test.describe('Verify round trips', () => {
6969
await page.goto(
7070
`/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenarioItems.id}`
7171
);
72-
await roundTripPage.removeViteOverlay();
7372
await waitForInfraStateToBeCached(infra.id);
7473
});
7574
await test.step('Open round trip page modal', async () => {

0 commit comments

Comments
 (0)