front: remove unnecessary removal of vite overlay

Since we already listen to console errors using page.on to fail the test, removing the vite overlay is no longer needed. If the overlay is visible in the UI, it indicates a real issue.

Signed-off-by: Maymanaf <med.aymen.naf@gmail.com>

Author: Maymanaf

front/tests/009-op-simulation-settings-tab.spec.ts

@@ -122,7 +122,6 @@ test.describe('Simulation Settings Tab Verification', () => {
       await page.goto(
         `/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenario.id}`
       );
-      await operationalStudiesPage.removeViteOverlay();
       await waitForInfraStateToBeCached(infra.id);
     });
     await test.step('Add a new train schedule, set its properties and perform pathfinding', async () => {

front/tests/010-stdcm.spec.ts

@@ -61,7 +61,6 @@ test.describe('Verify stdcm simulation page', () => {
     ];
 
     await page.goto('/stdcm');
-    await stdcmPage.removeViteOverlay();
     await waitForInfraStateToBeCached(infra.id);
   });
 

front/tests/011-stdcm-simulation-sheet.spec.ts

@@ -63,7 +63,6 @@ test.describe('Verify stdcm simulation page', () => {
     ];
 
     await page.goto('/stdcm');
-    await stdcmPage.removeViteOverlay();
     await waitForInfraStateToBeCached(infra.id);
   });
 

front/tests/012-stdcm-feedback-mail.spec.ts

@@ -48,7 +48,6 @@ test.describe('Stdcm feedback card', () => {
       new SimulationResultPage(page),
     ];
     await page.goto('/stdcm');
-    await stdcmPage.removeViteOverlay();
     await waitForInfraStateToBeCached(infra.id);
   });
 

front/tests/013-stdcm-linked-train.spec.ts

@@ -66,7 +66,6 @@ test.describe('Verify stdcm simulation page', () => {
     ];
 
     await page.goto('/stdcm');
-    await stdcmPage.removeViteOverlay();
     await waitForInfraStateToBeCached(infra.id);
   });
 

front/tests/014-stdcm-missing-fields.spec.ts

@@ -42,8 +42,6 @@ test.describe('Verify stdcm missing fields', () => {
     ];
 
     await page.goto('/stdcm');
-    await stdcmPage.removeViteOverlay();
-
     await waitForInfraStateToBeCached(infra.id);
   });
 

front/tests/015-train-timetable.spec.ts

@@ -31,7 +31,6 @@ import {
   VALID_PACED_TRAINS,
   VALID_TRAIN_SCHEDULE,
 } from './assets/constants/timetable-items-count';
-import OperationalStudiesPage from './pages/operational-studies/operational-studies-page';
 import PacedTrainSection from './pages/operational-studies/paced-train-section';
 import ScenarioTimetableSection from './pages/operational-studies/scenario-timetable-section';
 import { waitForInfraStateToBeCached } from './utils';
@@ -52,7 +51,6 @@ const frTranslations = {
 test.describe('Verify train schedule elements and filters', () => {
   let scenarioTimetableSection: ScenarioTimetableSection;
   let pacedTrainSection: PacedTrainSection;
-  let operationalStudiesPage: OperationalStudiesPage;
 
   let project: Project;
   let study: Study;
@@ -69,16 +67,14 @@ test.describe('Verify train schedule elements and filters', () => {
   test.beforeEach(
     'Navigate to scenario page and wait for infrastructure to be loaded',
     async ({ page }) => {
-      [operationalStudiesPage, scenarioTimetableSection, pacedTrainSection] = [
-        new OperationalStudiesPage(page),
+      [scenarioTimetableSection, pacedTrainSection] = [
         new ScenarioTimetableSection(page),
         new PacedTrainSection(page),
       ];
 
       await page.goto(
         `/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenario.id}`
       );
-      await operationalStudiesPage.removeViteOverlay();
       await waitForInfraStateToBeCached(infra.id);
     }
   );

front/tests/017-paced-train-management.spec.ts

@@ -120,7 +120,6 @@ test.describe('Verify simulation configuration in operational studies for train
       await page.goto(
         `/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenario.id}`
       );
-      await operationalStudiesPage.removeViteOverlay();
       await waitForInfraStateToBeCached(infra.id);
     }
   );

front/tests/021-get-manchette.spec.ts

@@ -102,7 +102,6 @@ test.describe('Verify manchette and space time diagram', () => {
     await page.goto(
       `/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenarioItems.id}`
     );
-    await simulationResultPage.removeViteOverlay();
     await waitForInfraStateToBeCached(infra.id);
   });
 

front/tests/022-round-trips.spec.ts

@@ -69,7 +69,6 @@ test.describe('Verify round trips', () => {
       await page.goto(
         `/operational-studies/projects/${project.id}/studies/${study.id}/scenarios/${scenarioItems.id}`
       );
-      await roundTripPage.removeViteOverlay();
       await waitForInfraStateToBeCached(infra.id);
     });
     await test.step('Open round trip page modal', async () => {